[SOLR-11314] FastCharStream should avoid creating new IOExceptions as a signaling mechanism

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.6.1, 7.0, 8.0
• Fix Version/s: 7.1, 8.0
• Assignee: David Smiley
• Reporter: Michael Braun
• Created: 02/Sep/17 21:59
• Updated: 08/Jun/19 15:22
• Resolved: 08/Sep/17 01:14

Description

FastCharStream is used internally by solr query parser classes. It throws a new IOException to signal the end. However, this is quite expensive relative to most operations and it shows up very high on samples for extremely high query cases. The IOException should be a single static instance that can be shared to avoid the overhead in creation and populating the stack trace, a stack trace which is never used.

Issue Links

• relates to: SOLR-11242 QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance