Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-11314

FastCharStream should avoid creating new IOExceptions as a signaling mechanism

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 6.6.1, 7.0, 8.0
    • 7.1, 8.0
    • None
    • None

    Description

      FastCharStream is used internally by solr query parser classes. It throws a new IOException to signal the end. However, this is quite expensive relative to most operations and it shows up very high on samples for extremely high query cases. The IOException should be a single static instance that can be shared to avoid the overhead in creation and populating the stack trace, a stack trace which is never used.

      Attachments

        1. SOLR-11314.patch
          1 kB
          Michael Braun
        2. TestQueryPerfSpeedup.java
          4 kB
          Michael Braun
        3. Screen Shot 2017-09-06 at 8.21.18 PM.png
          134 kB
          Michael Braun

        Issue Links

          Activity

            People

              dsmiley David Smiley
              mbraun688 Michael Braun
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: