Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-11254

add score-less (abstract) DocTransformer.transform method

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.1, master (8.0)
    • Component/s: None
    • Labels:
      None

      Description

      Background and motivation:

      • Most DocTransformer implementations don't use the score argument of the transform method.
      • Without the change being proposed in this ticket the fix for SOLR-11180 and SOLR-11220 (included in the SOLR-11164 patch) would need to also interpret a score of 0 to mean "no score".

      Summary of proposed change (for master and branch_7x branches):

      -  public abstract void transform(SolrDocument doc, int docid, float score) throws IOException;
      +  public void transform(SolrDocument doc, int docid, float score) throws IOException {
      +    transform(doc, docid);
      +  }
      +
      +  public abstract void transform(SolrDocument doc, int docid) throws IOException;
      

        Attachments

        1. SOLR-11254.patch
          15 kB
          Christine Poerschke

          Activity

            People

            • Assignee:
              cpoerschke Christine Poerschke
              Reporter:
              cpoerschke Christine Poerschke
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: