[SOLR-11242] QueryParser should avoid creating an LookaheadSuccess(Error) object with every instance

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.6.1, 7.0, 8.0
• Fix Version/s: 7.1
• Assignee: David Smiley
• Reporter: Michael Braun
• Created: 15/Aug/17 21:26
• Updated: 08/Jun/19 15:20
• Resolved: 03/Sep/17 21:01

Description

Sampling of an application which includes a very heavy query load testing against an EmbeddedSolrServer reveals a huge amount of the time spent on initialization of the QueryParser itself, specifically an internal class called LookaheadSuccess which extends from Error. With every instance of QueryParser created, it spends time populating the stacktrace for this object, which is created as a final instance variable (the variable called jj_ls).

Ideally an exception shouldn't be used as a signaling mechanism, or at the very least, not an exception created on every single object instantiation.

Issue Links

• is related to: SOLR-11314 FastCharStream should avoid creating new IOExceptions as a signaling mechanism