Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-11140

(private) SolrMetricManager.prepareCloudPlugins has unused parameter

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.1, 8.0
    • Component/s: metrics
    • Labels:
      None

      Description

      SolrMetricManager.prepareCloudPlugins is a private method and its last parameter (defaultPlugin) is always passed in as null leading to an effectively dead/unreachable block of code in the method implementation.

      This ticket proposes to remove the unused parameter and associated unreachable block of code.

        Attachments

          Activity

            People

            • Assignee:
              cpoerschke Christine Poerschke
              Reporter:
              cpoerschke Christine Poerschke

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment