Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-1106

Pluggable CoreAdminHandler (Action ) architecture that allows for custom handler access to CoreContainer / request-response

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4
    • Component/s: search
    • Labels:
      None
    • Environment:

      Java 5, Tomcat 6

      Description

      Currently there are certain default actions implemented in CoreAdminHandler ( CREATE , SWAP, RELOAD , ALIAS etc.) .

      For the purpose of in-house monitoring tools that needs to interact with multiple cores at a given solr instance - we need custom handlers that has access to CoreContainer and the req, resp of the same.

      So - the proposed way of injecting handlers is as follows.

      In solr.xml - we add a new schema -

      <solr >
      <cores adminPath="/cores/admin">

      <adminActionHandler action="newaction" handlerType="com.mydomain.myclass" />
      </cores>
      </solr>

      New abstract class - CoreAdminActionRequestHandler added - that com.mydomain.myclass would need to inherit from.

      Following action handlers registered by default -

      registerCustomAdminHandler("create", new AdminCreateActionRequestHandler());
      registerCustomAdminHandler("rename", new AdminRenameActionRequestHandler());
      registerCustomAdminHandler("alias", new AdminAliasActionRequestHandler());
      registerCustomAdminHandler("unload", new AdminUnloadActionRequestHandler());
      registerCustomAdminHandler("status", new AdminStatusActionRequestHandler());
      registerCustomAdminHandler("persist", new AdminPersistActionRequestHandler());
      registerCustomAdminHandler("reload", new AdminReloadActionRequestHandler());
      registerCustomAdminHandler("swap", new AdminSwapActionRequestHandler());

      Trying to register a handler with one that already exists would result in an error ( Hence - the above mentioned defaults would not be overridden).

        Attachments

        1. SOLR-1106.patch
          5 kB
          Noble Paul
        2. SOLR-1106.patch
          20 kB
          Shalin Shekhar Mangar
        3. SOLR-1106.patch
          19 kB
          Karthik K
        4. SOLR-1106.patch
          7 kB
          Karthik K
        5. SOLR-1106.patch
          7 kB
          Karthik K
        6. SOLR-1106.patch
          29 kB
          Karthik K

        Issue Links

          Activity

            People

            • Assignee:
              shalin Shalin Shekhar Mangar
              Reporter:
              kaykay.unique Karthik K

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 3h
                3h
                Remaining:
                Remaining Estimate - 3h
                3h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Issue deployment