Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-11004

Consolidate SolrClient Builder code in abstract parent class

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 7.0
    • SolrJ
    • None

    Description

      As anshumg pointed out in SOLR-10456, the Builder code for each SolrClient has a lot of duplication in it.

      For example, each SolrClient allows configuration of the connection timeout: all 4 builders have a field to store this value, all 4 builders have a withConnectionTimeout method to set this value, and all 4 builders have very similar Javadocs documenting what this value can be used for.

      The same can be said for 5 or 6 other properties common to most/all SolrClient's.

      This duplication could be removed by creating an abstract SolrClientBuilder class, which each of the specific Builders extend.

      Attachments

        1. SOLR-11004.patch
          14 kB
          Anshum Gupta
        2. SOLR-11004.patch
          15 kB
          Jason Gerlowski

        Activity

          People

            anshum Anshum Gupta
            gerlowskija Jason Gerlowski
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: