Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10912

Adding automatic patch validation

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 7.4
    • Build
    • None

    Description

      Proposing introduction of automated patch validation, similar what Hadoop or other Apache projects are using (see link). This would ensure that every patch passes a certain set of criterions before getting approved. It would save time for developer (faster feedback loop), save time for committers (less step to do manually), and would increase quality.

      Hadoop is currently using Apache Yetus to run validations, which seems to be a good direction to start. This jira could be the board of discussing the preferred solution.

      Attachments

        1. SOLR-10912.ok-patch-in-core.patch
          1 kB
          Mano Kovacs
        2. SOLR-10912.patch
          21 kB
          Steven Rowe
        3. SOLR-10912.patch
          21 kB
          Steven Rowe
        4. SOLR-10912.sample-patch.patch
          0.5 kB
          Mano Kovacs
        5. SOLR-10912.solj-contrib-facet-error.patch
          2 kB
          Mano Kovacs

        Issue Links

        depends upon

        New Feature - A new feature of the product, which has yet to be developed. YETUS-537 Personality for SOLR

        • Major - Major loss of function.
        • Resolved
        is related to

        Bug - A problem which impairs or prevents the functions of the product. INFRA-16094 Please change text on JIRA "Submit Patch" button to "Submit issue for automated Patch Review" OSLT (but probably shorter, I mean seriously, it's a button ffs)

        • Major - Major loss of function.
        • Closed

        Task - A task that needs to be done. LUCENE-8515 Jenkins patch validation: upgrade Yetus to 0.8.0

        • Minor - Minor loss of function, or other problem where easy workaround is present.
        • Open
        relates to

        Test - A new unit, integration or system test. LUCENE-8210 Validate patch validation

        • Major - Major loss of function.
        • Resolved

        Test - A new unit, integration or system test. SOLR-12106 Validate patch validation (solr edition)

        • Trivial - Cosmetic problem like misspelt words or misaligned text.
        • Resolved

        Project - Which project does this relate to? INFRA-15213 Adjust LUCENE and SOLR projects' workflow to include the "Patch Available" status

        • Major - Major loss of function.
        • Closed

        Project - Which project does this relate to? INFRA-16194 Add SOLR and LUCENE to JIRA filter for Jenkins PreCommit-Admin job

        • Major - Major loss of function.
        • Closed
        links to

        Web Link HADOOP-14538

        Web Link Patch Naming

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            sarowe Steven Rowe
            manokovacs Mano Kovacs
            Votes:
            1 Vote for this issue
            Watchers:
            14 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment