[SOLR-10779] JavaBinCodec should use close consistently rather than having marshal() and close() call finish() (which closes the underlying stream)

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.0
• Assignee: Erick Erickson
• Reporter: Erick Erickson
• Created: 31/May/17 04:38
• Updated: 21/Nov/19 00:42
• Resolved: 19/Jun/17 05:51

Description

Having the marshal() code call finish which in turn calls close() is trappy. The marshal code is not robust anyway since if there's an exception before the try loop, it will not close the resource.

Sub task of SOLR-10778

Issue Links

• relates to: SOLR-10778 Address precommit WARNINGS