Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9735 Umbrella JIRA for Auto Scaling and Cluster Management in SolrCloud
  3. SOLR-10738

TriggerAction is initialised even if the trigger is never scheduled

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 7.1, 8.0
    • SolrCloud
    • None

    Description

      The zk watcher responsible for creating triggers creates them blindly without checking if the trigger is actually modified. This is be design as ScheduledTriggers.add is a no-op if the trigger being added is unchanged. However, since the trigger's actions are initialised in the trigger's constructor, they are inited needlessly by the zk watcher thread even though we may never schedule those trigger instances (because they are unchanged). So I propose to change the TriggerAction lifecycle such that the TriggerAction.init is only called when the trigger is actually ready to be scheduled.

      Attachments

        1. SOLR-10738.patch
          3 kB
          Shalin Shekhar Mangar
        2. SOLR-10738-fix.patch
          4 kB
          Shalin Shekhar Mangar
        3. SOLR-10738-tests.patch
          17 kB
          Shalin Shekhar Mangar

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            shalin Shalin Shekhar Mangar
            shalin Shalin Shekhar Mangar
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment