[SOLR-10734] Multithreaded test/support for AtomicURP broken

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.4, 8.0
• Assignee: Shalin Shekhar Mangar
• Reporter: Ishan Chattopadhyaya
• Created: 23/May/17 15:58
• Updated: 02/Oct/19 17:24
• Resolved: 28/Mar/18 07:27

Description

The multithreaded test doesn't actually start the threads, but only invokes the run directly. The join afterwards doesn't do anything, hence.

diff --git a/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java b/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java
index f3f833d..10b7770 100644
--- a/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java
+++ b/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java
@@ -238,7 +238,7 @@ public class AtomicUpdateProcessorFactoryTest extends SolrTestCaseJ4 {
           }
         }
       };
-      t.run();
+      t.run(); // red flag, shouldn't this be t.start?
       threads.add(t);
       finalCount += index; //int_i
     }

Issue Links

• relates to: SOLR-11311 Improving AtomicUpdateProcessorFactoryTest