Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10734

Multithreaded test/support for AtomicURP broken

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.4, 8.0
    • Component/s: None
    • Labels:
      None

      Description

      The multithreaded test doesn't actually start the threads, but only invokes the run directly. The join afterwards doesn't do anything, hence.

      diff --git a/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java b/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java
      index f3f833d..10b7770 100644
      --- a/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java
      +++ b/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java
      @@ -238,7 +238,7 @@ public class AtomicUpdateProcessorFactoryTest extends SolrTestCaseJ4 {
                 }
               }
             };
      -      t.run();
      +      t.run(); // red flag, shouldn't this be t.start?
             threads.add(t);
             finalCount += index; //int_i
           }
      

        Attachments

        1. testResultsMaster_10
          52 kB
          Amrit Sarkar
        2. testResults7_10
          47 kB
          Amrit Sarkar
        3. testMaster_2500
          94 kB
          Amrit Sarkar
        4. SOLR-10734-fix2.patch
          4 kB
          Shalin Shekhar Mangar
        5. SOLR-10734-fix2.patch
          3 kB
          Shalin Shekhar Mangar
        6. SOLR-10734.patch
          3 kB
          Amrit Sarkar
        7. SOLR-10734.patch
          1 kB
          Amrit Sarkar
        8. SOLR-10734.patch
          1 kB
          Amrit Sarkar
        9. SOLR-10734.patch
          2 kB
          Shalin Shekhar Mangar
        10. Screen Shot 2017-05-31 at 4.50.23 PM.png
          729 kB
          Amrit Sarkar
        11. log-snippet
          119 kB
          Amrit Sarkar

          Issue Links

            Activity

              People

              • Assignee:
                shalinmangar Shalin Shekhar Mangar
                Reporter:
                ichattopadhyaya Ishan Chattopadhyaya
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: