Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.6, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      see an awesome finding by Andrey Kudryavtsev, also we can request post tool to output the Solr response.

      1. SOLR-10614.patch
        13 kB
        Mikhail Khludnev
      2. SOLR-10614.patch
        8 kB
        Mikhail Khludnev
      3. TestPostToolThenExamplesCLI.java
        1 kB
        Mikhail Khludnev

        Activity

        Hide
        mkhludnev Mikhail Khludnev added a comment -

        oh yeah.. it seems like TestSolrCLIRunExample.testTechproductsExample fails when the same JVM runs SimplePostToolTest and assigns SimplePostTool.mockMode that's PAIN.

        Show
        mkhludnev Mikhail Khludnev added a comment - oh yeah.. it seems like TestSolrCLIRunExample.testTechproductsExample fails when the same JVM runs SimplePostToolTest and assigns SimplePostTool.mockMode that's PAIN.
        Hide
        mkhludnev Mikhail Khludnev added a comment -

        meet the reproducer TestPostToolThenExamplesCLI.java ... I'm still crying.

        Show
        mkhludnev Mikhail Khludnev added a comment - meet the reproducer TestPostToolThenExamplesCLI.java ... I'm still crying.
        Hide
        mkhludnev Mikhail Khludnev added a comment -

        SOLR-10614.patch has the same reproducer suite and also ugly Tes_t names. I don't think we need to commit this.
        What's gonna be committed is removing static fields from SimplePostTool, and I'll also add "mock" flag in output to catch such tricks in future.

        Show
        mkhludnev Mikhail Khludnev added a comment - SOLR-10614.patch has the same reproducer suite and also ugly Tes_t names. I don't think we need to commit this. What's gonna be committed is removing static fields from SimplePostTool, and I'll also add "mock" flag in output to catch such tricks in future.
        Hide
        mkhludnev Mikhail Khludnev added a comment -

        eager to commit.

        Show
        mkhludnev Mikhail Khludnev added a comment - eager to commit.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit dbe6fc5d8f63b4ac87ae015f1cf79ec89c271a01 in lucene-solr's branch refs/heads/master from Mikhail Khludnev
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dbe6fc5 ]

        SOLR-10614: remove static backdoor fields from SimplePostTool.
        Enabling testTechproductsExample

        Show
        jira-bot ASF subversion and git services added a comment - Commit dbe6fc5d8f63b4ac87ae015f1cf79ec89c271a01 in lucene-solr's branch refs/heads/master from Mikhail Khludnev [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dbe6fc5 ] SOLR-10614 : remove static backdoor fields from SimplePostTool. Enabling testTechproductsExample
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit dbd4c1b1262900620edba0cd67361483ea98e154 in lucene-solr's branch refs/heads/branch_6x from Mikhail Khludnev
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dbd4c1b ]

        SOLR-10614: remove static backdoor fields from SimplePostTool.
        Enabling testTechproductsExample

        Show
        jira-bot ASF subversion and git services added a comment - Commit dbd4c1b1262900620edba0cd67361483ea98e154 in lucene-solr's branch refs/heads/branch_6x from Mikhail Khludnev [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dbd4c1b ] SOLR-10614 : remove static backdoor fields from SimplePostTool. Enabling testTechproductsExample

          People

          • Assignee:
            Unassigned
            Reporter:
            mkhludnev Mikhail Khludnev
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development