Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10552

numBuckets is not consistent between distrib and non-distrib requests

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.1
    • Fix Version/s: 6.6
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      The main problem is mincount... in a non-distrib query, numBuckets reflects the number of buckets that are screened out after mincount is applied. In distributed mode, we can't do this (or rather, the only way to do it would be to tramsmit all bucket counts to an aggregator node).

      We should perhaps just make numBuckets always pre-mincount to be consistent, and use hyper-log-log by default?

        Activity

        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        Here's a patch that uses the existing hll aggregator for distributed requests, as well as making numBuckets be calculated before mincount is applied.

        Show
        yseeley@gmail.com Yonik Seeley added a comment - Here's a patch that uses the existing hll aggregator for distributed requests, as well as making numBuckets be calculated before mincount is applied.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 71ce0d31a6a907bf1566fc51324d5f26e4205c21 in lucene-solr's branch refs/heads/master from Yonik Seeley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=71ce0d3 ]

        SOLR-10548: SOLR-10552: numBuckets should use hll and ignore mincount>1 filtering

        Show
        jira-bot ASF subversion and git services added a comment - Commit 71ce0d31a6a907bf1566fc51324d5f26e4205c21 in lucene-solr's branch refs/heads/master from Yonik Seeley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=71ce0d3 ] SOLR-10548 : SOLR-10552 : numBuckets should use hll and ignore mincount>1 filtering
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1f67ddda7699e1889d600f3f155dd910d71e864f in lucene-solr's branch refs/heads/branch_6x from Yonik Seeley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1f67ddd ]

        SOLR-10548: SOLR-10552: numBuckets should use hll and ignore mincount>1 filtering

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1f67ddda7699e1889d600f3f155dd910d71e864f in lucene-solr's branch refs/heads/branch_6x from Yonik Seeley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1f67ddd ] SOLR-10548 : SOLR-10552 : numBuckets should use hll and ignore mincount>1 filtering

          People

          • Assignee:
            yseeley@gmail.com Yonik Seeley
            Reporter:
            yseeley@gmail.com Yonik Seeley
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development