[SOLR-1053] SolrWriter.getResourceAsString IndexOutOfBoundsException

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3
• Fix Version/s: 1.4
• Component/s: contrib - DataImportHandler

Environment

All

• Assignee: Shalin Shekhar Mangar
• Reporter: Herb Jiang
• Created: 08/Mar/09 14:57
• Updated: 10/Nov/09 15:51
• Resolved: 09/Mar/09 14:56

Description

It will got excexception when the size of data-config.xml are times of 1024bytes.
Maybe it should check the sz==-1 when in.read(buf) reach the EOF.

#### ORIGINAL CODE ####
static String getResourceAsString(InputStream in) throws IOException {
    ByteArrayOutputStream baos = new ByteArrayOutputStream(1024);
    byte[] buf = new byte[1024];
    int sz = 0;
    try {
      while (true) {
        sz = in.read(buf);
        
        baos.write(buf, 0, sz);
        if (sz < buf.length)
          break;
      }
    } finally {
      try {
        in.close();
      } catch (Exception e) {

      }
    }
    return new String(baos.toByteArray());
  }