Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10537

Add SolrParams.toLocalParamsString and ClientUtils.encodeLocalParamVal

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.6, 7.0
    • Component/s: SolrJ
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      SolrParams ought to have a toLocalParamsString method. I needed such a thing while working on SOLR-10526 but I thought it deserved it's own issue. In addition, this method needs to call QueryParsing.encodeLocalParamVal but that's in Solr core (not SolrJ) so I think it can be refactored/moved to ClientUtils. I've wanted to call such a method before in client code and there was none. Surprisingly it's only used by FacetComponent within Solr.

        Issue Links

          Activity

          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f45017b2d4597193929c587393bb4f2351d9cd06 in lucene-solr's branch refs/heads/master from David Smiley
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f45017b ]

          SOLR-10537: Added SolrParams.toLocalParamsString() and moved QP.encodeLocalParamVal to ClientUtils

          Show
          jira-bot ASF subversion and git services added a comment - Commit f45017b2d4597193929c587393bb4f2351d9cd06 in lucene-solr's branch refs/heads/master from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f45017b ] SOLR-10537 : Added SolrParams.toLocalParamsString() and moved QP.encodeLocalParamVal to ClientUtils
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 73d3a77ad5b9a99944c1d7c1b64192e2c528dcb3 in lucene-solr's branch refs/heads/branch_6x from David Smiley
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=73d3a77 ]

          SOLR-10537: Added SolrParams.toLocalParamsString() and moved QP.encodeLocalParamVal to ClientUtils

          (cherry picked from commit f45017b)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 73d3a77ad5b9a99944c1d7c1b64192e2c528dcb3 in lucene-solr's branch refs/heads/branch_6x from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=73d3a77 ] SOLR-10537 : Added SolrParams.toLocalParamsString() and moved QP.encodeLocalParamVal to ClientUtils (cherry picked from commit f45017b)
          Hide
          mdrob Mike Drob added a comment -

          Why did you choose to do explicit Iterator rather than a for-each loop? Just readability?

          Show
          mdrob Mike Drob added a comment - Why did you choose to do explicit Iterator rather than a for-each loop? Just readability?
          Hide
          dsmiley David Smiley added a comment -

          Simply because toQueryString() does defined right above it. I didn't think about that detail honestly.

          Show
          dsmiley David Smiley added a comment - Simply because toQueryString() does defined right above it. I didn't think about that detail honestly.

            People

            • Assignee:
              dsmiley David Smiley
              Reporter:
              dsmiley David Smiley
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development