Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10472

Fix uninversioning of (single valued) PointFields & clean up some related code

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.6, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      In getting caught up with the new PointsField work in SOLR-8396 & SOLR-9987 I realized:

      • There's some inconsistencies/contridictions in how the new field types implement FieldType.getUninversionType vs some of the error handling added to methods like SchemaField.checkSortability.
      • as part of SOLR-9987, SORTED_foo constants were added to UninvertingReader and used in the getUninversionType methods for PointFields – even though those constants are useless (because UninvertingReader doesn't support uninverting multivalued points: SOLR-9202)
      • the changes made to methods like SchemaField.checkSortability to explicitly check isPointsField should have never been needed if those methods were paying attention to getUninversionType – but those types of checks weren't added when getUninversionType was introduced (the existing checks pre-date the DocValues API, back where any single-valued indexed field was implicitily "uninvertable")
      • If all of the above is corrected, the only thing preventing UninvertedReader from working properly with Solr's new PointField types (in the single valued case) is a trivial bug in IndexSchema (being presumptutious about what is uninvertable)

      I'm opening this issue to track fixing all of this, such that the end result will be:

      • single valued PointFields will be uninvertable (ie: sortable even if they don't have docvalues)
      • error handling code will be simplified
      • unused/unsupported/misleading constants in UninvertingReader will be removed.

        Attachments

        1. SOLR-10472.patch
          20 kB
          Hoss Man
        2. SOLR-10472.patch
          20 kB
          Hoss Man
        3. SOLR-10472.patch
          52 kB
          Hoss Man

          Issue Links

            Activity

              People

              • Assignee:
                hossman Hoss Man
                Reporter:
                hossman Hoss Man
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: