Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8975 SolrClient setters should be deprecated in favor of SolrClientBuilder methods
  3. SOLR-10456

timeout-related setters should be deprecated in favor of SolrClientBuilder methods

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 7.0
    • SolrJ
    • None

    Description

      Now that builders are in place for SolrClients, the setters used in each SolrClient can be deprecated, and their functionality moved over to the Builders. This change brings a few benefits:

      • unifies SolrClient configuration under the new Builders. It'll be nice to have all the knobs, and levers used to tweak {{SolrClient}}s available in a single place (the Builders).
      • reduces SolrClient thread-safety concerns. Currently, clients are mutable. Using some SolrClient setters can result in erratic and "trappy" behavior when the clients are used across multiple threads.

      This subtask endeavors to change this behavior for the setConnectionTimeout and setSoTimeout setters on all SolrClient implementations.

      Attachments

        1. SOLR-10456.patch
          93 kB
          Jason Gerlowski
        2. SOLR-10456.patch
          92 kB
          Jason Gerlowski
        3. SOLR-10456.patch
          89 kB
          Jason Gerlowski
        4. SOLR-10456.patch
          87 kB
          Jason Gerlowski

        Issue Links

          Activity

            People

              anshum Anshum Gupta
              gerlowskija Jason Gerlowski
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: