Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10451

Remove contrib/ltr/lib from lib includes in the techproducts example config

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.1, master (8.0)
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:

      Description

      As Varun Thacker mentioned in SOLR-8542 there are actually no jars in the contrib/ltr/lib folder.

      So to avoid confusion, let's remove the contrib/ltr folder from the Solr binary release (it currently contains just a boilerplate README.txt file).

      The <lib dir="${solr.install.dir:../../../..}/contrib/ltr/lib/" regex=".*\.jar" /> line in https://github.com/apache/lucene-solr/blob/master/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml can also be removed.

        Issue Links

          Activity

          Hide
          janhoy Jan Høydahl added a comment -

          I'm going to commit removal of <lib...> directive which prints a WARNING in logs.
          But I think the contrib/ltr folder can stay, it brings valuable info to new users that there is in fact an LTR contrib (even if it does not ship with 3rd party libs). Also the dataimporthandler contrib contains only a README.

          Show
          janhoy Jan Høydahl added a comment - I'm going to commit removal of <lib...> directive which prints a WARNING in logs. But I think the contrib/ltr folder can stay, it brings valuable info to new users that there is in fact an LTR contrib (even if it does not ship with 3rd party libs). Also the dataimporthandler contrib contains only a README.
          Hide
          janhoy Jan Høydahl added a comment -

          Patch

          Show
          janhoy Jan Høydahl added a comment - Patch
          Hide
          cpoerschke Christine Poerschke added a comment -

          ... But I think the contrib/ltr folder can stay, it brings valuable info to new users ... Also the dataimporthandler contrib contains only a README.

          Good point about info to new users and yes it makes sense to be consistent across contribs i.e. ltr and dataimporthandler to follow the same approach.

          +1 to the patch, thanks for taking care of this.

          Show
          cpoerschke Christine Poerschke added a comment - ... But I think the contrib/ltr folder can stay, it brings valuable info to new users ... Also the dataimporthandler contrib contains only a README. Good point about info to new users and yes it makes sense to be consistent across contribs i.e. ltr and dataimporthandler to follow the same approach. +1 to the patch, thanks for taking care of this.
          Hide
          gsingers Grant Ingersoll added a comment - - edited

          Was just looking at and created SOLR-10667. I think we should ship the examples which I think means keeping this folder. I was surprised they weren't there when I built the package and thus none of the LTR docs really applied.

          Show
          gsingers Grant Ingersoll added a comment - - edited Was just looking at and created SOLR-10667 . I think we should ship the examples which I think means keeping this folder. I was surprised they weren't there when I built the package and thus none of the LTR docs really applied.
          Hide
          janhoy Jan Høydahl added a comment -

          Modified the title and labeled this as newdev so some new committer could pick it up.
          Anyone, including Christine, feel free to assign yourself and complete it...

          Show
          janhoy Jan Høydahl added a comment - Modified the title and labeled this as newdev so some new committer could pick it up. Anyone, including Christine, feel free to assign yourself and complete it...
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user sungjunyoung opened a pull request:

          https://github.com/apache/lucene-solr/pull/249

          SOLR-10451: Remove contrib/ltr/lib from lib includes

          in the techproducts example config

          I deleted line 84 : `<lib dir="$

          {solr.install.dir:../../../..}

          /contrib/ltr/lib/" regex=".*\.jar" />`
          in [solrconfig.xml] file(https://github.com/apache/lucene-solr/blob/master/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml)

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/sungjunyoung/lucene-solr SOLR-10451

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/lucene-solr/pull/249.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #249


          commit 5f627025dcb08e3158823685917de1dfe98127b6
          Author: sungjunyoung <wnsdud1861@gmail.com>
          Date: 2017-09-19T03:47:58Z

          SOLR-10451: Remove contrib/ltr/lib from lib includes in the techproducts example config

          I deleted line84 : `<lib dir="$

          {solr.install.dir:../../../..}

          /contrib/ltr/lib/" regex=".*\.jar" />` in
          https://github.com/apache/lucene-solr/blob/master/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user sungjunyoung opened a pull request: https://github.com/apache/lucene-solr/pull/249 SOLR-10451 : Remove contrib/ltr/lib from lib includes in the techproducts example config I deleted line 84 : `<lib dir="$ {solr.install.dir:../../../..} /contrib/ltr/lib/" regex=".*\.jar" />` in [solrconfig.xml] file( https://github.com/apache/lucene-solr/blob/master/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml ) You can merge this pull request into a Git repository by running: $ git pull https://github.com/sungjunyoung/lucene-solr SOLR-10451 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/249.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #249 commit 5f627025dcb08e3158823685917de1dfe98127b6 Author: sungjunyoung <wnsdud1861@gmail.com> Date: 2017-09-19T03:47:58Z SOLR-10451 : Remove contrib/ltr/lib from lib includes in the techproducts example config I deleted line84 : `<lib dir="$ {solr.install.dir:../../../..} /contrib/ltr/lib/" regex=".*\.jar" />` in https://github.com/apache/lucene-solr/blob/master/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml
          Hide
          wnsdud1861 SungJunyoung added a comment -

          Is it right way to contribute to solr? Wanting to contribute, I made a pull-request with github.

          Show
          wnsdud1861 SungJunyoung added a comment - Is it right way to contribute to solr? Wanting to contribute, I made a pull-request with github.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit bc95209774fa4e1a998497ba224a15123d956ca1 in lucene-solr's branch refs/heads/master from Jan Høydahl
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=bc95209 ]

          SOLR-10451: Remove contrib/ltr/lib from lib includes in the techproducts example config. Fixes #249

          Show
          jira-bot ASF subversion and git services added a comment - Commit bc95209774fa4e1a998497ba224a15123d956ca1 in lucene-solr's branch refs/heads/master from Jan Høydahl [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=bc95209 ] SOLR-10451 : Remove contrib/ltr/lib from lib includes in the techproducts example config. Fixes #249
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/lucene-solr/pull/249

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/lucene-solr/pull/249
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 74d479ed23a5c916d7cfa43a3ab6e325202e68e1 in lucene-solr's branch refs/heads/branch_7x from Jan Høydahl
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=74d479e ]

          SOLR-10451: Remove contrib/ltr/lib from lib includes in the techproducts example config. Fixes #249

          (cherry picked from commit bc95209)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 74d479ed23a5c916d7cfa43a3ab6e325202e68e1 in lucene-solr's branch refs/heads/branch_7x from Jan Høydahl [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=74d479e ] SOLR-10451 : Remove contrib/ltr/lib from lib includes in the techproducts example config. Fixes #249 (cherry picked from commit bc95209)
          Hide
          janhoy Jan Høydahl added a comment -

          Thanks, a pull request is a good way to contribute. I just committed for you. Please continue contributing

          PS: When you create a PR, you can also start adding a line in CHANGES.txt the way you see I did. The line should be for the earliest version that we intend to include the fix in.

          Show
          janhoy Jan Høydahl added a comment - Thanks, a pull request is a good way to contribute. I just committed for you. Please continue contributing PS: When you create a PR, you can also start adding a line in CHANGES.txt the way you see I did. The line should be for the earliest version that we intend to include the fix in.
          Hide
          wnsdud1861 SungJunyoung added a comment -

          Kind of you. Thank you for your comment, I'll continue contributing

          Show
          wnsdud1861 SungJunyoung added a comment - Kind of you. Thank you for your comment, I'll continue contributing
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Bulk close after 7.1.0 release

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Bulk close after 7.1.0 release

            People

            • Assignee:
              janhoy Jan Høydahl
              Reporter:
              cpoerschke Christine Poerschke
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development