Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10451

Remove contrib/ltr/lib from lib includes in the techproducts example config

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:

      Description

      As Varun Thacker mentioned in SOLR-8542 there are actually no jars in the contrib/ltr/lib folder.

      So to avoid confusion, let's remove the contrib/ltr folder from the Solr binary release (it currently contains just a boilerplate README.txt file).

      The <lib dir="${solr.install.dir:../../../..}/contrib/ltr/lib/" regex=".*\.jar" /> line in https://github.com/apache/lucene-solr/blob/master/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml can also be removed.

        Issue Links

          Activity

          Hide
          janhoy Jan Høydahl added a comment -

          I'm going to commit removal of <lib...> directive which prints a WARNING in logs.
          But I think the contrib/ltr folder can stay, it brings valuable info to new users that there is in fact an LTR contrib (even if it does not ship with 3rd party libs). Also the dataimporthandler contrib contains only a README.

          Show
          janhoy Jan Høydahl added a comment - I'm going to commit removal of <lib...> directive which prints a WARNING in logs. But I think the contrib/ltr folder can stay, it brings valuable info to new users that there is in fact an LTR contrib (even if it does not ship with 3rd party libs). Also the dataimporthandler contrib contains only a README.
          Hide
          janhoy Jan Høydahl added a comment -

          Patch

          Show
          janhoy Jan Høydahl added a comment - Patch
          Hide
          cpoerschke Christine Poerschke added a comment -

          ... But I think the contrib/ltr folder can stay, it brings valuable info to new users ... Also the dataimporthandler contrib contains only a README.

          Good point about info to new users and yes it makes sense to be consistent across contribs i.e. ltr and dataimporthandler to follow the same approach.

          +1 to the patch, thanks for taking care of this.

          Show
          cpoerschke Christine Poerschke added a comment - ... But I think the contrib/ltr folder can stay, it brings valuable info to new users ... Also the dataimporthandler contrib contains only a README. Good point about info to new users and yes it makes sense to be consistent across contribs i.e. ltr and dataimporthandler to follow the same approach. +1 to the patch, thanks for taking care of this.
          Hide
          gsingers Grant Ingersoll added a comment - - edited

          Was just looking at and created SOLR-10667. I think we should ship the examples which I think means keeping this folder. I was surprised they weren't there when I built the package and thus none of the LTR docs really applied.

          Show
          gsingers Grant Ingersoll added a comment - - edited Was just looking at and created SOLR-10667 . I think we should ship the examples which I think means keeping this folder. I was surprised they weren't there when I built the package and thus none of the LTR docs really applied.
          Hide
          janhoy Jan Høydahl added a comment -

          Modified the title and labeled this as newdev so some new committer could pick it up.
          Anyone, including Christine, feel free to assign yourself and complete it...

          Show
          janhoy Jan Høydahl added a comment - Modified the title and labeled this as newdev so some new committer could pick it up. Anyone, including Christine, feel free to assign yourself and complete it...

            People

            • Assignee:
              Unassigned
              Reporter:
              cpoerschke Christine Poerschke
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:

                Development