Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10421

solr/contrib/ltr (MinMax|Standard)Normalizer.paramsToMap needs to save float as string

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 6.4, 6.4.1, 6.4.2, 6.5
    • 6.5.1, 6.6, 7.0
    • None
    • None

    Description

      Please see Jianxiong Dong's solr learning_to_rank (normalizer) unmatched argument type issue email on the user mailing list for details on how this bug manifests.

      Implementation choice background:

      • If the number were to be saved as a number then 4.2 could be considered either as a float or as a double and hence the normalizer classes would need setters for both those possibilities. Equally, 42.0 could be saved as just 42 which then could be either an int or a long and so again setters for both possibilities would be needed. All this complexity is avoided by saving the number as a string. The class has convenience float setters which can be handy for use in tests.

      Attachments

        1. SOLR-10421.patch
          3 kB
          Christine Poerschke

        Issue Links

          Activity

            People

              cpoerschke Christine Poerschke
              cpoerschke Christine Poerschke
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: