[SOLR-10415] Within solr-core, debug/trace level logging should use parameterized log messages

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 8.6
• Component/s: logging
• Assignee: Unassigned
• Reporter: Michael Braun
• Created: 04/Apr/17 02:12
• Updated: 08/Dec/21 13:10
• Resolved: 01/May/20 17:19

Description

Noticed in several samplings of an active Solr that several debug statements were taking decently measurable time because of the time of the .toString even when the log.debug() statement would not output because it was effectively INFO or higher. Using parameterized logging statements, ie 'log.debug("Blah {}", o)' will avoid incurring that cost.

Issue Links

• is fixed by: LUCENE-7788 fail precommit on unparameterised log messages and examine for wasted work/objects
• is related to: LUCENE-7788 fail precommit on unparameterised log messages and examine for wasted work/objects
• relates to: SOLR-11884 find/fix inefficiencies in our use of logging
• relates to: SOLR-12286 Wrap log instances in "if (LOG.isLevelEnabled) { log... }
• links to: GitHub Pull Request #182
• links to: GitHub Pull Request #182

Sub-Tasks

• Clean up debug logging statements in solr-core's search package: Closed