Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10394

search.grouping.Command rename: getSortWithinGroup --> getWithinGroupSort

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.6, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      The class is marked @lucene.experimental and SOLR-9660 previously included sortSpecWithinGroup to withinGroupSortSpec renaming for GroupSpecification; the rename proposed here is in line with that.

      Motivation for the change is to reduce group-sort vs. within-group-sort confusion, generally and specifically in SOLR-6203.

      1. SOLR-10394.patch
        4 kB
        Christine Poerschke
      2. SOLR-10394-part2.patch
        16 kB
        Christine Poerschke

        Issue Links

          Activity

          Hide
          cpoerschke Christine Poerschke added a comment -

          Attaching proposed patch, factored out from Judith Silverman's SOLR-6203 changes.

          Show
          cpoerschke Christine Poerschke added a comment - Attaching proposed patch, factored out from Judith Silverman 's SOLR-6203 changes.
          Hide
          cpoerschke Christine Poerschke added a comment -

          Committed to master and branch_6x this afternoon, not sure why the ASF Bot didn't add an update here (my git was also hanging when pushing).

          Show
          cpoerschke Christine Poerschke added a comment - Committed to master and branch_6x this afternoon, not sure why the ASF Bot didn't add an update here (my git was also hanging when pushing). master: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/05749d06 branch_6x: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/bec07b0a
          Hide
          cpoerschke Christine Poerschke added a comment -

          Attaching 'part 2' patch which is essentially non-public sortWithinGroup to withinGroupSort renames, for clarity and to reduce the complexity of the SOLR-6203 changes.

          Show
          cpoerschke Christine Poerschke added a comment - Attaching 'part 2' patch which is essentially non-public sortWithinGroup to withinGroupSort renames, for clarity and to reduce the complexity of the SOLR-6203 changes.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 323c972922c5d2e272ef4558cf725e5d9ccef623 in lucene-solr's branch refs/heads/master from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=323c972 ]

          SOLR-10394: a few more essentially non-public sortWithinGroup to withinGroupSort renames

          Show
          jira-bot ASF subversion and git services added a comment - Commit 323c972922c5d2e272ef4558cf725e5d9ccef623 in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=323c972 ] SOLR-10394 : a few more essentially non-public sortWithinGroup to withinGroupSort renames
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 4b30834bc8a5f1744594d8c6ff1bad05d3691655 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4b30834 ]

          SOLR-10394: a few more essentially non-public sortWithinGroup to withinGroupSort renames

          Resolved Conflict:
          solr/core/src/java/org/apache/solr/search/grouping/distributed/command/TopGroupsFieldCommand.java

          Show
          jira-bot ASF subversion and git services added a comment - Commit 4b30834bc8a5f1744594d8c6ff1bad05d3691655 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4b30834 ] SOLR-10394 : a few more essentially non-public sortWithinGroup to withinGroupSort renames Resolved Conflict: solr/core/src/java/org/apache/solr/search/grouping/distributed/command/TopGroupsFieldCommand.java
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jitka18 commented on the issue:

          https://github.com/apache/lucene-solr/pull/189

          Hi, Christine. I accepted your pull request and will update my branch from
          the master later today. Will also take a look at the tests in DQCCST.

          Thanks,
          Judith

          On Wed, Apr 19, 2017 at 1:19 PM, Christine Poerschke <
          notifications@github.com> wrote:

          > Hi Judith - thanks for adding me to the collaborator list. I've added one
          > more commit to the jitka18#1
          > <https://github.com/jitka18/lucene-solr/pull/1> request and would suggest
          > something along the following lines as the next steps:
          >
          > - to review jitka18#1 <https://github.com/jitka18/lucene-solr/pull/1>
          > and if it looks good merge it into your jira/solr-6203 branch and/or add
          > comments on the pull request
          > - to merge the latest master (at the time) into the jira/solr-6203
          > working branch
          > ** this will give some merge conflicts that need to be resolved
          > ** this will somewhat reduce the scope and complexity of the changes
          > for the working branch since SOLR-10394 part-2 renames will be picked up
          > from the latest master
          > - to see if new code duplication in DistributedQueryComponentCustomSortTest
          > can be reduced further, this will not just reduce the amount of code but
          > will (i think) also help with clarity i.e. what is being tested
          >
          > How does that sound? Any questions, please let me know. - Christine
          >
          > —
          > You are receiving this because you authored the thread.
          > Reply to this email directly, view it on GitHub
          > <https://github.com/apache/lucene-solr/pull/189#issuecomment-295423545>,
          > or mute the thread
          > <https://github.com/notifications/unsubscribe-auth/AZdiss7MqSiBLhVpl4Bb7Ud__PZTDCe1ks5rxmxhgaJpZM4M-ruZ>
          > .
          >

          Show
          githubbot ASF GitHub Bot added a comment - Github user jitka18 commented on the issue: https://github.com/apache/lucene-solr/pull/189 Hi, Christine. I accepted your pull request and will update my branch from the master later today. Will also take a look at the tests in DQCCST. Thanks, Judith On Wed, Apr 19, 2017 at 1:19 PM, Christine Poerschke < notifications@github.com> wrote: > Hi Judith - thanks for adding me to the collaborator list. I've added one > more commit to the jitka18#1 > < https://github.com/jitka18/lucene-solr/pull/1 > request and would suggest > something along the following lines as the next steps: > > - to review jitka18#1 < https://github.com/jitka18/lucene-solr/pull/1 > > and if it looks good merge it into your jira/solr-6203 branch and/or add > comments on the pull request > - to merge the latest master (at the time) into the jira/solr-6203 > working branch > ** this will give some merge conflicts that need to be resolved > ** this will somewhat reduce the scope and complexity of the changes > for the working branch since SOLR-10394 part-2 renames will be picked up > from the latest master > - to see if new code duplication in DistributedQueryComponentCustomSortTest > can be reduced further, this will not just reduce the amount of code but > will (i think) also help with clarity i.e. what is being tested > > How does that sound? Any questions, please let me know. - Christine > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > < https://github.com/apache/lucene-solr/pull/189#issuecomment-295423545 >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AZdiss7MqSiBLhVpl4Bb7Ud__PZTDCe1ks5rxmxhgaJpZM4M-ruZ > > . >

            People

            • Assignee:
              cpoerschke Christine Poerschke
              Reporter:
              cpoerschke Christine Poerschke
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development