Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10344

Update Solr default/example and test configs to use WordDelimiterGraphFilterFactory

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.6, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      WordDelimiterFilterFactory was deprecated in LUCENE-7619

        Issue Links

          Activity

          Hide
          steve_rowe Steve Rowe added a comment -

          Patch converting schema uses of WordDelimiterFilterFactory to WordDelimiterGraphFilterFactory. In index analyzers, a FlattenGraphFilterFactory is added as the last filter; and in fieldtypes with a dual purpose <analyzer>, the analyzer is split into index and query analyzers, and the FlattenGraphFilterFactory is added to the index analyzer.

          Running all Solr tests and precommit now.

          Show
          steve_rowe Steve Rowe added a comment - Patch converting schema uses of WordDelimiterFilterFactory to WordDelimiterGraphFilterFactory. In index analyzers, a FlattenGraphFilterFactory is added as the last filter; and in fieldtypes with a dual purpose <analyzer> , the analyzer is split into index and query analyzers, and the FlattenGraphFilterFactory is added to the index analyzer. Running all Solr tests and precommit now.
          Hide
          steve_rowe Steve Rowe added a comment -

          Final patch: fixed a copy/paste-o; switched order of expected overlapping tokens output from WordDelimiterGraphFilter+FlattenGraphFilter; in one field type in one schema, moved FlattenGraphFilter right after WordDelimiterGraphFilter, to avoid FlattenGraphFilter complaining about apparent reordering caused by PorterStemFilterFactory.

          All Solr tests and precommit pass. Committing shortly.

          Show
          steve_rowe Steve Rowe added a comment - Final patch: fixed a copy/paste-o; switched order of expected overlapping tokens output from WordDelimiterGraphFilter+FlattenGraphFilter; in one field type in one schema, moved FlattenGraphFilter right after WordDelimiterGraphFilter, to avoid FlattenGraphFilter complaining about apparent reordering caused by PorterStemFilterFactory. All Solr tests and precommit pass. Committing shortly.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 4b45c2720ebd9eb5aa87326c42c96ceda72ef4dd in lucene-solr's branch refs/heads/branch_6x from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4b45c27 ]

          SOLR-10344: Update Solr default/example and test configs to use WordDelimiterGraphFilterFactory

          Show
          jira-bot ASF subversion and git services added a comment - Commit 4b45c2720ebd9eb5aa87326c42c96ceda72ef4dd in lucene-solr's branch refs/heads/branch_6x from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4b45c27 ] SOLR-10344 : Update Solr default/example and test configs to use WordDelimiterGraphFilterFactory
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit b46b8278c60102eeaeb45dddf239356746da7de8 in lucene-solr's branch refs/heads/master from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b46b827 ]

          SOLR-10344: Update Solr default/example and test configs to use WordDelimiterGraphFilterFactory

          Show
          jira-bot ASF subversion and git services added a comment - Commit b46b8278c60102eeaeb45dddf239356746da7de8 in lucene-solr's branch refs/heads/master from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b46b827 ] SOLR-10344 : Update Solr default/example and test configs to use WordDelimiterGraphFilterFactory
          Hide
          janhoy Jan Høydahl added a comment -

          Please update fix version to 6.6

          Show
          janhoy Jan Høydahl added a comment - Please update fix version to 6.6
          Hide
          steve_rowe Steve Rowe added a comment -

          Please update fix version to 6.6

          Done, thanks Jan Høydahl.

          Show
          steve_rowe Steve Rowe added a comment - Please update fix version to 6.6 Done, thanks Jan Høydahl .

            People

            • Assignee:
              steve_rowe Steve Rowe
              Reporter:
              tomasflobbe Tomás Fernández Löbbe
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development