Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10343

Update Solr default/example and test configs to use SynonymGraphFilterFactory

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.6, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      SynonymFilterFactory was deprecated in LUCENE-6664

        Issue Links

          Activity

          Hide
          janhoy Jan Høydahl added a comment -

          Do we have proper QueryParser support for actually doing multi-term synonym expansion on query side? I know we have sow support, but is this enough?

          Show
          janhoy Jan Høydahl added a comment - Do we have proper QueryParser support for actually doing multi-term synonym expansion on query side? I know we have sow support, but is this enough?
          Hide
          steve_rowe Steve Rowe added a comment -

          Do we have proper QueryParser support for actually doing multi-term synonym expansion on query side? I know we have sow support, but is this enough?

          I think it's enough, at least for the standard and edismax query parsers. See the test I added under SOLR-9185: TestMultiWordSynonyms.

          Show
          steve_rowe Steve Rowe added a comment - Do we have proper QueryParser support for actually doing multi-term synonym expansion on query side? I know we have sow support, but is this enough? I think it's enough, at least for the standard and edismax query parsers. See the test I added under SOLR-9185 : TestMultiWordSynonyms .
          Hide
          steve_rowe Steve Rowe added a comment -

          Patch converting schema uses of SynonymFilterFactory to SynonymGraphFilterFactory. In index analyzers, a FlattenGraphFilterFactory is added as the last filter; and in fieldtypes with a dual purpose <analyzer>, the analyzer is split into index and query analyzers, and the FlattenGraphFilterFactory is added to the index analyzer.

          Not included here: switching ManagedSynonymFilterFactory to use SynonymGraphFilterFactory as its delegate. I'll make a separate issue.

          Running all Solr tests and precommit now.

          Show
          steve_rowe Steve Rowe added a comment - Patch converting schema uses of SynonymFilterFactory to SynonymGraphFilterFactory. In index analyzers, a FlattenGraphFilterFactory is added as the last filter; and in fieldtypes with a dual purpose <analyzer>, the analyzer is split into index and query analyzers, and the FlattenGraphFilterFactory is added to the index analyzer. Not included here: switching ManagedSynonymFilterFactory to use SynonymGraphFilterFactory as its delegate. I'll make a separate issue. Running all Solr tests and precommit now.
          Hide
          steve_rowe Steve Rowe added a comment -

          Not included here: switching ManagedSynonymFilterFactory to use SynonymGraphFilterFactory as its delegate. I'll make a separate issue.

          Done: SOLR-10379

          Show
          steve_rowe Steve Rowe added a comment - Not included here: switching ManagedSynonymFilterFactory to use SynonymGraphFilterFactory as its delegate. I'll make a separate issue. Done: SOLR-10379
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9705e95988060fd800000d1c8c995fef56ab4ea8 in lucene-solr's branch refs/heads/branch_6x from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9705e95 ]

          SOLR-10343: Update Solr default/example and test configs to use SynonymGraphFilterFactory

          Show
          jira-bot ASF subversion and git services added a comment - Commit 9705e95988060fd800000d1c8c995fef56ab4ea8 in lucene-solr's branch refs/heads/branch_6x from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9705e95 ] SOLR-10343 : Update Solr default/example and test configs to use SynonymGraphFilterFactory
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1a80e4d6942dd7af214c999e0e6540564efc02ac in lucene-solr's branch refs/heads/master from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1a80e4d ]

          SOLR-10343: Update Solr default/example and test configs to use SynonymGraphFilterFactory

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1a80e4d6942dd7af214c999e0e6540564efc02ac in lucene-solr's branch refs/heads/master from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1a80e4d ] SOLR-10343 : Update Solr default/example and test configs to use SynonymGraphFilterFactory

            People

            • Assignee:
              steve_rowe Steve Rowe
              Reporter:
              tomasflobbe Tomás Fernández Löbbe
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development