Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10316

Unloading a core can remove a ZK SolrCore registration entry for the wrong SolrCore.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.6, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      We only use core node name and collection to match in ZK#unregister(core).

      This means if a registration was taken over (either via manual user interaction or auto add replicas), unloading a core can remove a ZK entry it should not.

      1. SOLR-10316.patch
        3 kB
        Mark Miller
      2. SOLR-10316.patch
        2 kB
        Mark Miller

        Issue Links

          Activity

          Hide
          markrmiller@gmail.com Mark Miller added a comment -

          Patch is off. Was in the weeds a bit. The extra info we need to use can't be core name because it could be the same. We may have to pass the base url for it to match against.

          Show
          markrmiller@gmail.com Mark Miller added a comment - Patch is off. Was in the weeds a bit. The extra info we need to use can't be core name because it could be the same. We may have to pass the base url for it to match against.
          Hide
          markrmiller@gmail.com Mark Miller added a comment -

          Here is a patch that tries to match baseUrl on core unload.

          Show
          markrmiller@gmail.com Mark Miller added a comment - Here is a patch that tries to match baseUrl on core unload.
          Hide
          markrmiller@gmail.com Mark Miller added a comment -

          Here is the correct patch.

          Show
          markrmiller@gmail.com Mark Miller added a comment - Here is the correct patch.
          Hide
          markrmiller@gmail.com Mark Miller added a comment -

          I'll commit this shortly if there is no objection.

          Show
          markrmiller@gmail.com Mark Miller added a comment - I'll commit this shortly if there is no objection.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 366a5d242e431ddcddf7c6396f1da8696a835928 in lucene-solr's branch refs/heads/master from Mark Miller
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=366a5d2 ]

          SOLR-10316: Unloading a core can remove a ZK SolrCore registration entry for the wrong SolrCore.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 366a5d242e431ddcddf7c6396f1da8696a835928 in lucene-solr's branch refs/heads/master from Mark Miller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=366a5d2 ] SOLR-10316 : Unloading a core can remove a ZK SolrCore registration entry for the wrong SolrCore.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit a975385d58a0197e18b9d16397f9691eb7dbbf0a in lucene-solr's branch refs/heads/branch_6x from Mark Miller
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a975385 ]

          SOLR-10316: Unloading a core can remove a ZK SolrCore registration entry for the wrong SolrCore.

          Show
          jira-bot ASF subversion and git services added a comment - Commit a975385d58a0197e18b9d16397f9691eb7dbbf0a in lucene-solr's branch refs/heads/branch_6x from Mark Miller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a975385 ] SOLR-10316 : Unloading a core can remove a ZK SolrCore registration entry for the wrong SolrCore.

            People

            • Assignee:
              markrmiller@gmail.com Mark Miller
              Reporter:
              markrmiller@gmail.com Mark Miller
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development