Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10304

Refactor Document/Stored-field handling out of SolrIndexSearcher

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 6.6
    • None
    • None

    Description

      SolrIndexSearcher is nearly 3 thousand lines of code. A sizable part of it pertains to Document handling, including various stored-field concerns and docValue substitutions (docValueAsStored related). There are already comments marking the start and end of this part of SolrIndexSearcher, plus there some fields and their initialization that are only in support of those methods. I propose that all of this go to a new companion class SolrDocumentFetcher. SolrIndexSearcher can add a getter for it, and where applicable existing callers can call to this instead. "Override"'s will need to stay of course.
      ( Originally proposed in SOLR-10286 )

      Attachments

        1. SOLR_10304_SolrDocumentFetcher.patch
          74 kB
          David Smiley
        2. SOLR_10304_SolrDocumentFetcher.patch
          84 kB
          David Smiley

        Activity

          People

            dsmiley David Smiley
            dsmiley David Smiley
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: