Solr
  1. Solr
  2. SOLR-1029

Standardize Evaluator parameter handling

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.4
    • Labels:
      None

      Description

      The evaluator parameter syntax is not well defined and inconsistent in some places. This issue aims to standardize on the following:

      1. String parameters should be enclosed in a single quote
      2. Variables can be written as-is
      3. Numbers (integers or floats) can be written as-is

      We will enforce this among the existing evaluators and provide helper functions for this parsing which future implementations can use.

      1. SOLR-1029.patch
        19 kB
        Shalin Shekhar Mangar
      2. SOLR-1029.patch
        14 kB
        Noble Paul

        Activity

        Hide
        Noble Paul added a comment -

        EvaluatorBag.parseParams() can do the parsing of function params in the standard format.

        a change to the existing function formatDate() the second parameter must be enclosed in single quotes

        Show
        Noble Paul added a comment - EvaluatorBag.parseParams() can do the parsing of function params in the standard format. a change to the existing function formatDate() the second parameter must be enclosed in single quotes
        Hide
        Shalin Shekhar Mangar added a comment -
        1. Made the behavior backwards-compatible with old syntax.
        2. Added warning if old syntax is used.

        I'll commit this shortly.

        Show
        Shalin Shekhar Mangar added a comment - Made the behavior backwards-compatible with old syntax. Added warning if old syntax is used. I'll commit this shortly.
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed revision 747291.

        Thanks Noble!

        Show
        Shalin Shekhar Mangar added a comment - Committed revision 747291. Thanks Noble!
        Hide
        Shalin Shekhar Mangar added a comment -

        I added a note on this for users upgrading from 1.3

        Show
        Shalin Shekhar Mangar added a comment - I added a note on this for users upgrading from 1.3
        Hide
        Grant Ingersoll added a comment -

        Bulk close for Solr 1.4

        Show
        Grant Ingersoll added a comment - Bulk close for Solr 1.4

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Shalin Shekhar Mangar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development