Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10283

SolrFeature fails to reject searches with missing efi (if used by fq)

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 6.4, 6.4.1, 6.4.2
    • Fix Version/s: 6.5, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      My intention had been to update the Solr Reference Guide's Learning To Rank section w.r.t. External Feature Information i.e. https://cwiki.apache.org/confluence/display/solr/Learning+To+Rank#LearningToRank-ExternalFeatureInformation based on the https://lists.apache.org/thread.html/17547c1487067804077b1933ccde28d68841ec1694f6776c5682f28e@%3Csolr-user.lucene.apache.org%3E user mailing list thread.

      In the process I noticed that configuring a feature such as this

      {
        "store" : "myEfiFeatureStore",
        "name" : "isPreferredManufacturer",
        "class" : "org.apache.solr.ltr.feature.SolrFeature",
        "params" : { "fq" : [ "{!field f=manu}${preferredManufacturer}" ] }
      }
      

      and then not passing efi.preferredManufacturer=something is not rejected and instead a score of 1.0 is returned for the feature.

      This seems unexpected i.e. a bug.

      1. SOLR-10283.patch
        2 kB
        Christine Poerschke
      2. SOLR-10283.patch
        7 kB
        Christine Poerschke

        Issue Links

          Activity

          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 61b94ae3995872765f4e5b257576a651083ce4ca in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=61b94ae ]

          SOLR-10283: Learning to Rank (LTR) SolrFeature to reject searches with missing efi (External Feature Information) used by fq.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 61b94ae3995872765f4e5b257576a651083ce4ca in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=61b94ae ] SOLR-10283 : Learning to Rank (LTR) SolrFeature to reject searches with missing efi (External Feature Information) used by fq.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 17cc3e7dad7eb2f691767fc5a08aac8e6d055bdc in lucene-solr's branch refs/heads/master from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=17cc3e7 ]

          SOLR-10283: Learning to Rank (LTR) SolrFeature to reject searches with missing efi (External Feature Information) used by fq.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 17cc3e7dad7eb2f691767fc5a08aac8e6d055bdc in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=17cc3e7 ] SOLR-10283 : Learning to Rank (LTR) SolrFeature to reject searches with missing efi (External Feature Information) used by fq.
          Hide
          cpoerschke Christine Poerschke added a comment -

          Full patch including new test and adjustments to existing tests.

          Show
          cpoerschke Christine Poerschke added a comment - Full patch including new test and adjustments to existing tests.
          Hide
          cpoerschke Christine Poerschke added a comment -

          Partial patch, still needs new test and adjustments to existing tests.

          Show
          cpoerschke Christine Poerschke added a comment - Partial patch, still needs new test and adjustments to existing tests.

            People

            • Assignee:
              cpoerschke Christine Poerschke
              Reporter:
              cpoerschke Christine Poerschke
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development