Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10274

The search Streaming Expression should work in non-SolrCloud mode

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Resolved
    • Affects Version/s: None
    • Fix Version/s: 6.6, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      The search Streaming expression powers Solr's MapReduce queries, a large part of the SQL interface and graph expressions. So it would be great if it could work in non-SolrCloud mode as well.

      1. SOLR-10274.patch
        345 kB
        Joel Bernstein
      2. SOLR-10274.patch
        341 kB
        Joel Bernstein
      3. SOLR-10274.patch
        302 kB
        Joel Bernstein

        Activity

        Hide
        joel.bernstein Joel Bernstein added a comment - - edited

        This is a fairly small coding change but ends up affecting many of the test cases. That's because CloudSolrStream used to by lenient about setting the StreamContext, so most of the test cases didn't set the StreamContext. As part of this ticket CloudSolrStream now enforces the setting of StreamContext, so most of the test cases need to be adjusted to add the StreamContext.

        The /stream handler always properly sets the StreamContext so from a users standpoint enforcing the setting of the StreamContext shouldn't cause problems when upgrading.

        Show
        joel.bernstein Joel Bernstein added a comment - - edited This is a fairly small coding change but ends up affecting many of the test cases. That's because CloudSolrStream used to by lenient about setting the StreamContext, so most of the test cases didn't set the StreamContext. As part of this ticket CloudSolrStream now enforces the setting of StreamContext, so most of the test cases need to be adjusted to add the StreamContext. The /stream handler always properly sets the StreamContext so from a users standpoint enforcing the setting of the StreamContext shouldn't cause problems when upgrading.
        Hide
        joel.bernstein Joel Bernstein added a comment -

        Work in progress

        Show
        joel.bernstein Joel Bernstein added a comment - Work in progress
        Hide
        joel.bernstein Joel Bernstein added a comment -

        Work in progress continues...

        Show
        joel.bernstein Joel Bernstein added a comment - Work in progress continues...
        Hide
        joel.bernstein Joel Bernstein added a comment -

        Very close to committing with the latest patch. Will do some manual testing...

        Show
        joel.bernstein Joel Bernstein added a comment - Very close to committing with the latest patch. Will do some manual testing...
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 06a55b73b97db0a2cff490dcf40670079a953f60 in lucene-solr's branch refs/heads/master from Joel Bernstein
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=06a55b7 ]

        SOLR-10274: The search Streaming Expression should work in non-SolrCloud mode

        Show
        jira-bot ASF subversion and git services added a comment - Commit 06a55b73b97db0a2cff490dcf40670079a953f60 in lucene-solr's branch refs/heads/master from Joel Bernstein [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=06a55b7 ] SOLR-10274 : The search Streaming Expression should work in non-SolrCloud mode
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 5ebd41d13f646ea45a16e079c7fe4f3ff7e634cf in lucene-solr's branch refs/heads/master from Joel Bernstein
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5ebd41d ]

        SOLR-10274: fix precommit

        Show
        jira-bot ASF subversion and git services added a comment - Commit 5ebd41d13f646ea45a16e079c7fe4f3ff7e634cf in lucene-solr's branch refs/heads/master from Joel Bernstein [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5ebd41d ] SOLR-10274 : fix precommit
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit b03a7b1cfc9939206c8c802b3dca8ecbb6c2e94f in lucene-solr's branch refs/heads/branch_6x from Joel Bernstein
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b03a7b1 ]

        SOLR-10274: Fix backport

        Show
        jira-bot ASF subversion and git services added a comment - Commit b03a7b1cfc9939206c8c802b3dca8ecbb6c2e94f in lucene-solr's branch refs/heads/branch_6x from Joel Bernstein [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b03a7b1 ] SOLR-10274 : Fix backport
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 56e3bc7a54d1c0e1ec26f038e18fc87df2af559b in lucene-solr's branch refs/heads/branch_6x from Joel Bernstein
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=56e3bc7 ]

        SOLR-10274: fix precommit

        Show
        jira-bot ASF subversion and git services added a comment - Commit 56e3bc7a54d1c0e1ec26f038e18fc87df2af559b in lucene-solr's branch refs/heads/branch_6x from Joel Bernstein [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=56e3bc7 ] SOLR-10274 : fix precommit
        Hide
        erickerickson Erick Erickson added a comment -

        Should this still be open?

        Show
        erickerickson Erick Erickson added a comment - Should this still be open?
        Hide
        joel.bernstein Joel Bernstein added a comment -

        I have a whole bunch of tickets open that are going to be resolved for 6.6. This is one of them. In the next 3 or 4 days I'll wrap them all up.

        Show
        joel.bernstein Joel Bernstein added a comment - I have a whole bunch of tickets open that are going to be resolved for 6.6. This is one of them. In the next 3 or 4 days I'll wrap them all up.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 41ebeeaadcdf3e222719999c65dcea8712efb95d in lucene-solr's branch refs/heads/master from Joel Bernstein
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=41ebeea ]

        SOLR-10274: Update CHANGES.txt

        Show
        jira-bot ASF subversion and git services added a comment - Commit 41ebeeaadcdf3e222719999c65dcea8712efb95d in lucene-solr's branch refs/heads/master from Joel Bernstein [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=41ebeea ] SOLR-10274 : Update CHANGES.txt
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit a30d34b4846e6e2b2433cb0e00388e7a91283b43 in lucene-solr's branch refs/heads/branch_6x from Joel Bernstein
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a30d34b ]

        SOLR-10274: Update CHANGES.txt

        Show
        jira-bot ASF subversion and git services added a comment - Commit a30d34b4846e6e2b2433cb0e00388e7a91283b43 in lucene-solr's branch refs/heads/branch_6x from Joel Bernstein [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a30d34b ] SOLR-10274 : Update CHANGES.txt

          People

          • Assignee:
            joel.bernstein Joel Bernstein
            Reporter:
            joel.bernstein Joel Bernstein
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development