Solr
  1. Solr
  2. SOLR-1024

Calling abort on DataImportHandler import commits data

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.4
    • Labels:
      None

      Description

      If abort is called on an ongoing import, the import is cancelled but the data is committed. It should be rolledback.

      1. SOLR-1024.patch
        3 kB
        Shalin Shekhar Mangar

        Activity

        Hide
        Shalin Shekhar Mangar added a comment -

        In the current code, DocBuilder#abort is called in two place:

        1. When the user calls command=abort
        2. When using 'start' and 'rows' parameter to simulate aborting but committing anyway

        Patch to fix the problem

        Changes

        1. DocBuilder#abort is called only if command=abort is specified.
        2. DocBuilder#buildDocument is made aware of start and rows and it stops producing documents once it reaches the limit
        3. SolrWriter is no longer aware of start and rows and it does not call abort anymore.

        I'll commit this shortly.

        Show
        Shalin Shekhar Mangar added a comment - In the current code, DocBuilder#abort is called in two place: When the user calls command=abort When using 'start' and 'rows' parameter to simulate aborting but committing anyway Patch to fix the problem Changes DocBuilder#abort is called only if command=abort is specified. DocBuilder#buildDocument is made aware of start and rows and it stops producing documents once it reaches the limit SolrWriter is no longer aware of start and rows and it does not call abort anymore. I'll commit this shortly.
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed revision 745831.

        Show
        Shalin Shekhar Mangar added a comment - Committed revision 745831.
        Hide
        Grant Ingersoll added a comment -

        Bulk close for Solr 1.4

        Show
        Grant Ingersoll added a comment - Bulk close for Solr 1.4

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Shalin Shekhar Mangar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development