Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10224

Add disk free and aggregated disk free metrics

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 6.5, 7.0
    • Fix Version/s: 6.5, 7.0
    • Component/s: metrics
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      Spin-off from SOLR-9858. We kind of missed these when adding other OS-specific metrics.

      1. screenshot-1.png
        60 kB
        Andrzej Bialecki
      2. SOLR-10224.patch
        4 kB
        Andrzej Bialecki

        Activity

        Hide
        ab Andrzej Bialecki added a comment -

        An open question: we can create solr.jvm metrics for each accessible FileStore, but that may be a lot of metrics, and some of them are of very limited value (eg. procfs, tmpfs, devpts and similar), so it looks like we should at least leave out some common less-than-useful filesystem types.

        Example result of FileSystems.getDefault().getFileStores():

        / (/dev/root)
        /dev (devtmpfs)
        /sys (sysfs)
        /proc (proc)
        /dev/shm (tmpfs)
        /dev/pts (devpts)
        /run (tmpfs)
        /run/lock (tmpfs)
        /sys/fs/cgroup (tmpfs)
        /sys/fs/cgroup/systemd (cgroup)
        /sys/fs/cgroup/cpu,cpuacct (cgroup)
        /sys/fs/cgroup/blkio (cgroup)
        /sys/fs/cgroup/memory (cgroup)
        /sys/fs/cgroup/devices (cgroup)
        /sys/fs/cgroup/freezer (cgroup)
        /sys/fs/cgroup/net_cls (cgroup)
        /proc/sys/fs/binfmt_misc (systemd-1)
        /dev/mqueue (mqueue)
        /sys/kernel/debug (debugfs)
        /sys/kernel/config (configfs)
        /sys/fs/fuse/connections (fusectl)
        /boot (/dev/mmcblk0p6)
        /run/user/1000 (tmpfs)
        /run/user/1000/gvfs (gvfsd-fuse)
        

        Another option is to report just the filesystem where dataDir is located, for each SolrCore.

        Show
        ab Andrzej Bialecki added a comment - An open question: we can create solr.jvm metrics for each accessible FileStore , but that may be a lot of metrics, and some of them are of very limited value (eg. procfs, tmpfs, devpts and similar), so it looks like we should at least leave out some common less-than-useful filesystem types. Example result of FileSystems.getDefault().getFileStores() : / (/dev/root) /dev (devtmpfs) /sys (sysfs) /proc (proc) /dev/shm (tmpfs) /dev/pts (devpts) /run (tmpfs) /run/lock (tmpfs) /sys/fs/cgroup (tmpfs) /sys/fs/cgroup/systemd (cgroup) /sys/fs/cgroup/cpu,cpuacct (cgroup) /sys/fs/cgroup/blkio (cgroup) /sys/fs/cgroup/memory (cgroup) /sys/fs/cgroup/devices (cgroup) /sys/fs/cgroup/freezer (cgroup) /sys/fs/cgroup/net_cls (cgroup) /proc/sys/fs/binfmt_misc (systemd-1) /dev/mqueue (mqueue) /sys/kernel/debug (debugfs) /sys/kernel/config (configfs) /sys/fs/fuse/connections (fusectl) /boot (/dev/mmcblk0p6) /run/user/1000 (tmpfs) /run/user/1000/gvfs (gvfsd-fuse) Another option is to report just the filesystem where dataDir is located, for each SolrCore.
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Another option is to report just the filesystem where dataDir is located, for each SolrCore.

        +1 to this. Also, the usage stats of coreRootDirectory of CoreContainer should be reported.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Another option is to report just the filesystem where dataDir is located, for each SolrCore. +1 to this. Also, the usage stats of coreRootDirectory of CoreContainer should be reported.
        Hide
        ab Andrzej Bialecki added a comment -

        Patch that adds metrics for each dataDir and for NodeConfig.getCoreRootDirectory(). See also the screenshot.

        Show
        ab Andrzej Bialecki added a comment - Patch that adds metrics for each dataDir and for NodeConfig.getCoreRootDirectory() . See also the screenshot.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1192d396dd5f1384b6cee290f1b9210c5aad8d9e in lucene-solr's branch refs/heads/master from Andrzej Bialecki
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1192d39 ]

        SOLR-10224: Add disk total and disk free metrics.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1192d396dd5f1384b6cee290f1b9210c5aad8d9e in lucene-solr's branch refs/heads/master from Andrzej Bialecki [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1192d39 ] SOLR-10224 : Add disk total and disk free metrics.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 8d72579cee0a84ea140969cbdc4817e70c1f3f24 in lucene-solr's branch refs/heads/branch_6x from Andrzej Bialecki
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8d72579 ]

        SOLR-10224: Add disk total and disk free metrics.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 8d72579cee0a84ea140969cbdc4817e70c1f3f24 in lucene-solr's branch refs/heads/branch_6x from Andrzej Bialecki [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8d72579 ] SOLR-10224 : Add disk total and disk free metrics.

          People

          • Assignee:
            ab Andrzej Bialecki
            Reporter:
            ab Andrzej Bialecki
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development