Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10219

diagnose HDFS test problems with Java9 and/or re-enable these tests

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.5, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:

      Description

      As part of SOLR-8874, Uwe disabled all HDFS based tests under java9 at the build.xml/pom.xml level by adding a conditional to the existing tests.disableHdfs system property (Note: this property exists so that HDFS tests can be disabled by default on windows, but still run on cygwin if users wish to set that property)

      We need to get to the bottom of what exactly the issue(s) are with HDFS and file specific bugs to track the problems

        Issue Links

          Activity

          Hide
          hossman Hoss Man added a comment -

          The specific commits...

          I've been manually experimenting running (nightly) tests on java9 (build 9-ea+157) with tests.disableHdfs=false and I've yet to encounter any test failures.

          I suspect maybe this change was a mistake? perhaps what Uwe was seeing was a lot of failures realted to classes in hadoops java package due to other bugs like SOLR-8876 & SOLR-10199 – which don't always use HDFS, and now have their own assumeFalse(JRE_IS_MINIMUM_JAVA9) logic.

          Uwe Schindler – do you remember the specific motivations for the tests.disableHdfs=true if java9 change? do any tests fail for you on your java9 install if you revert that?

          Show
          hossman Hoss Man added a comment - The specific commits... https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;a=blobdiff;f=solr/common-build.xml;h=d2672587edc11c535dd4d10ec30af200731bd3f2;hp=78e10aabac17f1aeaffd6f97d1bbf53fd6085360;hb=f93f90c;hpb=cc774994fc0faa3711f762b3c51b4d011739f628 https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3a4e1d1 I've been manually experimenting running (nightly) tests on java9 (build 9-ea+157) with tests.disableHdfs=false and I've yet to encounter any test failures. I suspect maybe this change was a mistake? perhaps what Uwe was seeing was a lot of failures realted to classes in hadoops java package due to other bugs like SOLR-8876 & SOLR-10199 – which don't always use HDFS, and now have their own assumeFalse(JRE_IS_MINIMUM_JAVA9) logic. Uwe Schindler – do you remember the specific motivations for the tests.disableHdfs=true if java9 change? do any tests fail for you on your java9 install if you revert that?
          Hide
          thetaphi Uwe Schindler added a comment -

          Hi Hoss Man,

          it could be that some problems were solved also by updating Hadoop versions recently. I don't remember the exact causes for changing build.xml. It could be that this was also caused by the mentioned issues.

          If all is fine on Linux, I'd change the common-build.xml and remove the Java 9 special case and leave HDFS with Windows disabled only.

          Show
          thetaphi Uwe Schindler added a comment - Hi Hoss Man , it could be that some problems were solved also by updating Hadoop versions recently. I don't remember the exact causes for changing build.xml. It could be that this was also caused by the mentioned issues. If all is fine on Linux, I'd change the common-build.xml and remove the Java 9 special case and leave HDFS with Windows disabled only.
          Hide
          thetaphi Uwe Schindler added a comment -

          It could also be that the Java 9 people made some adjustments, so it is more compatible to Hadoop. So I have no idea, but in my Linux VM at that time I have seen tons of failures primarily on Hadoop tests, so I disabled them.

          Be sure to check again with build 158, as there were some changes, including SecurityManager.

          Otherwise +1 to revert the above 2 commits done by me. Hoss Man: Should I do it, or will you do it? I'd take the issue in that case.

          Show
          thetaphi Uwe Schindler added a comment - It could also be that the Java 9 people made some adjustments, so it is more compatible to Hadoop. So I have no idea, but in my Linux VM at that time I have seen tons of failures primarily on Hadoop tests, so I disabled them. Be sure to check again with build 158, as there were some changes, including SecurityManager. Otherwise +1 to revert the above 2 commits done by me. Hoss Man : Should I do it, or will you do it? I'd take the issue in that case.
          Hide
          hossman Hoss Man added a comment -

          Uwe: I'm still testing ... i'll take care of it.

          Show
          hossman Hoss Man added a comment - Uwe: I'm still testing ... i'll take care of it.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 4851f399d4b25f76eeb494d7c63844bf6b858fd5 in lucene-solr's branch refs/heads/master from Chris Hostetter
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4851f39 ]

          SOLR-10219: stop defaulting to tests.disableHdfs=true under java9

          Show
          jira-bot ASF subversion and git services added a comment - Commit 4851f399d4b25f76eeb494d7c63844bf6b858fd5 in lucene-solr's branch refs/heads/master from Chris Hostetter [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4851f39 ] SOLR-10219 : stop defaulting to tests.disableHdfs=true under java9
          Hide
          hossman Hoss Man added a comment -

          Uwe Schindler: i think we're fine ... even with b158 ... i've pushed a "revert" of tests.disableHdfs=true if java9 to master and i'll let it soak for a few days before backporting.

          If you notice any suspcious hadoop/hdfs related failures under java9, can you please file new jiras for them w/stack traces – and (when you feel it's warranted) add assumeFalse(Constants.JRE_IS_MINIMUM_JAVA9) pointed at those distinct jiras.

          (I'd prefer we leave tests.disableHdfs alone for now so we can more precisely assess individual bugs)

          Show
          hossman Hoss Man added a comment - Uwe Schindler : i think we're fine ... even with b158 ... i've pushed a "revert" of tests.disableHdfs=true if java9 to master and i'll let it soak for a few days before backporting. If you notice any suspcious hadoop/hdfs related failures under java9, can you please file new jiras for them w/stack traces – and (when you feel it's warranted) add assumeFalse(Constants.JRE_IS_MINIMUM_JAVA9) pointed at those distinct jiras. (I'd prefer we leave tests.disableHdfs alone for now so we can more precisely assess individual bugs)
          Hide
          thetaphi Uwe Schindler added a comment -

          Thanks Hoss!

          Show
          thetaphi Uwe Schindler added a comment - Thanks Hoss!
          Hide
          thetaphi Uwe Schindler added a comment -

          Hi Hoss,
          Policeman did not see any new Java 9 test failures. I think you can cherry-pick your last commit in branch_6x.

          Show
          thetaphi Uwe Schindler added a comment - Hi Hoss, Policeman did not see any new Java 9 test failures. I think you can cherry-pick your last commit in branch_6x.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 708d08063df71e3380f533345a47b87a8ac728b6 in lucene-solr's branch refs/heads/branch_6x from Chris Hostetter
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=708d080 ]

          SOLR-10219: re-enable HDFS tests under JDK9 (CHANGES.txt entry)

          (cherry picked from commit da113fde771adf0b1a6b4676533e8e02cab41f9a)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 708d08063df71e3380f533345a47b87a8ac728b6 in lucene-solr's branch refs/heads/branch_6x from Chris Hostetter [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=708d080 ] SOLR-10219 : re-enable HDFS tests under JDK9 (CHANGES.txt entry) (cherry picked from commit da113fde771adf0b1a6b4676533e8e02cab41f9a)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit efdef8993c6f8a5d1d00bc3da2c4091c6dcd63a2 in lucene-solr's branch refs/heads/branch_6x from Chris Hostetter
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=efdef89 ]

          SOLR-10219: stop defaulting to tests.disableHdfs=true under java9

          (cherry picked from commit 4851f399d4b25f76eeb494d7c63844bf6b858fd5)

          Show
          jira-bot ASF subversion and git services added a comment - Commit efdef8993c6f8a5d1d00bc3da2c4091c6dcd63a2 in lucene-solr's branch refs/heads/branch_6x from Chris Hostetter [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=efdef89 ] SOLR-10219 : stop defaulting to tests.disableHdfs=true under java9 (cherry picked from commit 4851f399d4b25f76eeb494d7c63844bf6b858fd5)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit da113fde771adf0b1a6b4676533e8e02cab41f9a in lucene-solr's branch refs/heads/master from Chris Hostetter
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=da113fd ]

          SOLR-10219: re-enable HDFS tests under JDK9 (CHANGES.txt entry)

          Show
          jira-bot ASF subversion and git services added a comment - Commit da113fde771adf0b1a6b4676533e8e02cab41f9a in lucene-solr's branch refs/heads/master from Chris Hostetter [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=da113fd ] SOLR-10219 : re-enable HDFS tests under JDK9 (CHANGES.txt entry)
          Hide
          hossman Hoss Man added a comment -

          ... I think you can cherry-pick your last commit in branch_6x.

          Yup, yup – branch_6x tests seemed to be working fine for me as well, so pushing the backport & CHANGES entry.

          Show
          hossman Hoss Man added a comment - ... I think you can cherry-pick your last commit in branch_6x. Yup, yup – branch_6x tests seemed to be working fine for me as well, so pushing the backport & CHANGES entry.

            People

            • Assignee:
              hossman Hoss Man
              Reporter:
              hossman Hoss Man
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development