Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.6
    • Component/s: metrics
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      Many (most) of the block cache metrics are unused (I assume just inherited from Blur) and unmaintained (i.e. most will be 0). Currently only the size and number of evictions is tracked.

      We should remove unused stats and start tracking

      • number of lookups (or number of misses)
      • number of hits
      • number of inserts
      • number of store failures
      1. SOLR-10214.patch
        9 kB
        Yonik Seeley
      2. SOLR-10214.patch
        8 kB
        Yonik Seeley

        Activity

        Hide
        ab Andrzej Bialecki added a comment -

        Perhaps this is a good opportunity to use the new metrics API here?

        Show
        ab Andrzej Bialecki added a comment - Perhaps this is a good opportunity to use the new metrics API here?
        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        Here's a draft patch that

        • removes a lot of the unused metrics
        • adds totals for lookups, hits, evictions... the previous metrics only reported per-second stats since the last call
        • moves the tracking of hit/miss from BlockDirectoryCache to BlockCache
        Show
        yseeley@gmail.com Yonik Seeley added a comment - Here's a draft patch that removes a lot of the unused metrics adds totals for lookups, hits, evictions... the previous metrics only reported per-second stats since the last call moves the tracking of hit/miss from BlockDirectoryCache to BlockCache
        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        Updated patch that starts tracking store failures (i.e. not being able to cache a block due to contention) as well as some other little cleanups.

        Show
        yseeley@gmail.com Yonik Seeley added a comment - Updated patch that starts tracking store failures (i.e. not being able to cache a block due to contention) as well as some other little cleanups.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 34bb7f31e546856094cb378b9d12c9ac7540e7e2 in lucene-solr's branch refs/heads/master from Yonik Seeley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=34bb7f3 ]

        SOLR-10214: clean up BlockCache Metrics, add storeFails and counts

        Show
        jira-bot ASF subversion and git services added a comment - Commit 34bb7f31e546856094cb378b9d12c9ac7540e7e2 in lucene-solr's branch refs/heads/master from Yonik Seeley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=34bb7f3 ] SOLR-10214 : clean up BlockCache Metrics, add storeFails and counts
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 5af1b8ad455a86dfe26cbda4889da5c1aa11ce31 in lucene-solr's branch refs/heads/branch_6x from Yonik Seeley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5af1b8a ]

        SOLR-10214: clean up BlockCache Metrics, add storeFails and counts

        Show
        jira-bot ASF subversion and git services added a comment - Commit 5af1b8ad455a86dfe26cbda4889da5c1aa11ce31 in lucene-solr's branch refs/heads/branch_6x from Yonik Seeley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5af1b8a ] SOLR-10214 : clean up BlockCache Metrics, add storeFails and counts
        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        Perhaps this is a good opportunity to use the new metrics API here?

        Oops, sorry Andrzej, I previously missed this comment.
        I don't know anything about the new metrics API yet, and I was just doing some simple cleanup here in pursuit of SOLR-10205 (I wanted to start tracking storeFails).
        I'll keep this issue open for now in case someone wants to tackle converting to the new API... we can just tack that onto this issue if it's before 6.5

        Show
        yseeley@gmail.com Yonik Seeley added a comment - Perhaps this is a good opportunity to use the new metrics API here? Oops, sorry Andrzej, I previously missed this comment. I don't know anything about the new metrics API yet, and I was just doing some simple cleanup here in pursuit of SOLR-10205 (I wanted to start tracking storeFails). I'll keep this issue open for now in case someone wants to tackle converting to the new API... we can just tack that onto this issue if it's before 6.5
        Hide
        ab Andrzej Bialecki added a comment - - edited

        This has been fixed on master as a part of SOLR-9959, but porting it to 6x would be a bit messy - specifically, I'd like to avoid introducing the MetricsMap and related MetricsUtils/JMX changes to 6x.

        Edit: I may need to do that (carefully) anyway due to SOLR-10000.

        Show
        ab Andrzej Bialecki added a comment - - edited This has been fixed on master as a part of SOLR-9959 , but porting it to 6x would be a bit messy - specifically, I'd like to avoid introducing the MetricsMap and related MetricsUtils/JMX changes to 6x. Edit: I may need to do that (carefully) anyway due to SOLR-10000 .
        Hide
        ab Andrzej Bialecki added a comment -

        SOLR-10000 exposed these stats using the new metrics API.

        Show
        ab Andrzej Bialecki added a comment - SOLR-10000 exposed these stats using the new metrics API.

          People

          • Assignee:
            Unassigned
            Reporter:
            yseeley@gmail.com Yonik Seeley
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development