Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10182

Backout directory metrics collection that caused performance degradation

    Details

    • Type: Task
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 6.4, 6.4.1
    • Fix Version/s: 6.4.2, 6.5, 7.0
    • Component/s: metrics
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      The performance degradation we observed as per SOLR-10130 will go away if directory factory level metrics collection is disabled by default. However, since they will cause the same degradation when enabled, we should back out those changes until we find a performant way of implementing such metrics collection.

      1. SOLR-10182.patch
        13 kB
        Andrzej Bialecki

        Issue Links

          Activity

          Hide
          ab Andrzej Bialecki added a comment -

          This patch completely removes Directory-level metrics collection.

          Show
          ab Andrzej Bialecki added a comment - This patch completely removes Directory-level metrics collection.
          Hide
          ichattopadhyaya Ishan Chattopadhyaya added a comment -

          +1, LGTM.

          Show
          ichattopadhyaya Ishan Chattopadhyaya added a comment - +1, LGTM.
          Hide
          markus17 Markus Jelsma added a comment -

          Yes, i applied both patches to our 6.4.1 and deployed it. Solr is running fast once again.

          Show
          markus17 Markus Jelsma added a comment - Yes, i applied both patches to our 6.4.1 and deployed it. Solr is running fast once again.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f622d0ef2bf66245cdf11f3abc67851d9ed73a44 in lucene-solr's branch refs/heads/branch_6_4 from Andrzej Bialecki
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f622d0e ]

          SOLR-10182 Remove metrics collection at Directory level.

          Show
          jira-bot ASF subversion and git services added a comment - Commit f622d0ef2bf66245cdf11f3abc67851d9ed73a44 in lucene-solr's branch refs/heads/branch_6_4 from Andrzej Bialecki [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f622d0e ] SOLR-10182 Remove metrics collection at Directory level.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f78e1c6866eb7707d5a802851a85bcfffcaa904e in lucene-solr's branch refs/heads/branch_6x from Andrzej Bialecki
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f78e1c6 ]

          SOLR-10182 Remove metrics collection at Directory level.

          Show
          jira-bot ASF subversion and git services added a comment - Commit f78e1c6866eb7707d5a802851a85bcfffcaa904e in lucene-solr's branch refs/heads/branch_6x from Andrzej Bialecki [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f78e1c6 ] SOLR-10182 Remove metrics collection at Directory level.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit a248e6e3c080cfe6deb873d1ef114e4b9c1c043d in lucene-solr's branch refs/heads/master from Andrzej Bialecki
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a248e6e ]

          SOLR-10182 Remove metrics collection at Directory level.

          Show
          jira-bot ASF subversion and git services added a comment - Commit a248e6e3c080cfe6deb873d1ef114e4b9c1c043d in lucene-solr's branch refs/heads/master from Andrzej Bialecki [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a248e6e ] SOLR-10182 Remove metrics collection at Directory level.

            People

            • Assignee:
              ab Andrzej Bialecki
              Reporter:
              ichattopadhyaya Ishan Chattopadhyaya
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development