Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10174

fix 3x in @Ignore TestLTRReRankingPipeline and TestMultipleAdditiveTreesModel

    Details

    • Type: Test
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.1, master (8.0)
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Issue Links

        Activity

        Hide
        cpoerschke Christine Poerschke added a comment -

        Some more details on the steps involved here:

        # optional: add a note to this ticket just to say that you plan to work on this, so as to collaborate with anyone else who might also plan to do the same.
        
        # checkout master branch and probably create a working branch e.g. 'git checkout -b master-solr-10174'
        # baseline compile e.g. 'ant compile'
        
        # run all the ltr tests e.g.
        cd solr/contrib/ltr
        ant test
        
        # remove the @Ignore annotation(s)
        
        # re-run the changed test(s) individually
        
        # once
        ant test -Dtestcase=TestLTRReRankingPipeline
        
        # or multiple times e.g.
        ant beast -Dbeast.iters=10 -Dtestcase=TestLTRReRankingPipeline
        
        # now the fun part, investigate any test failures
        # make changes
        # re-run test(s)
        
        # share findings on this ticket and/or changes e.g. via patch or github pull request
        

        And of course throughout, feel free to ask questions

        Show
        cpoerschke Christine Poerschke added a comment - Some more details on the steps involved here: # optional: add a note to this ticket just to say that you plan to work on this , so as to collaborate with anyone else who might also plan to do the same. # checkout master branch and probably create a working branch e.g. 'git checkout -b master-solr-10174' # baseline compile e.g. 'ant compile' # run all the ltr tests e.g. cd solr/contrib/ltr ant test # remove the @Ignore annotation(s) # re-run the changed test(s) individually # once ant test -Dtestcase=TestLTRReRankingPipeline # or multiple times e.g. ant beast -Dbeast.iters=10 -Dtestcase=TestLTRReRankingPipeline # now the fun part, investigate any test failures # make changes # re-run test(s) # share findings on this ticket and/or changes e.g. via patch or github pull request And of course throughout, feel free to ask questions
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit bcce49c160d356435f6e47a92172ae136ae49acf in lucene-solr's branch refs/heads/master from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=bcce49c ]

        SOLR-10174: fix @Ignore in TestMultipleAdditiveTreesModel

        Show
        jira-bot ASF subversion and git services added a comment - Commit bcce49c160d356435f6e47a92172ae136ae49acf in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=bcce49c ] SOLR-10174 : fix @Ignore in TestMultipleAdditiveTreesModel
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 972cdef6d9d75fdcb3f66f60901530edbf4ebad0 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=972cdef ]

        SOLR-10174: fix @Ignore in TestMultipleAdditiveTreesModel

        Show
        jira-bot ASF subversion and git services added a comment - Commit 972cdef6d9d75fdcb3f66f60901530edbf4ebad0 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=972cdef ] SOLR-10174 : fix @Ignore in TestMultipleAdditiveTreesModel
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit cf9b70b25365b194261cf7c3b6e32ec3330295dc in lucene-solr's branch refs/heads/master from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cf9b70b ]

        SOLR-10174: reduce makeFeatureWeights code duplication in tests

        Show
        jira-bot ASF subversion and git services added a comment - Commit cf9b70b25365b194261cf7c3b6e32ec3330295dc in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cf9b70b ] SOLR-10174 : reduce makeFeatureWeights code duplication in tests
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c09d6b0f73ba703b57efab864e927a504e65b433 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c09d6b0 ]

        SOLR-10174: reduce makeFeatureWeights code duplication in tests

        Show
        jira-bot ASF subversion and git services added a comment - Commit c09d6b0f73ba703b57efab864e927a504e65b433 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c09d6b0 ] SOLR-10174 : reduce makeFeatureWeights code duplication in tests
        Hide
        cpoerschke Christine Poerschke added a comment -

        Partial patch to fix approx. 1 of 2 @Ignore-ed tests.

        Show
        cpoerschke Christine Poerschke added a comment - Partial patch to fix approx. 1 of 2 @Ignore-ed tests.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c17333621d5535e294f3122baa25dbdef8ab77dd in lucene-solr's branch refs/heads/master from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c173336 ]

        SOLR-10174: fix approx. 1 of 2 @Ignore-ed tests in TestLTRReRankingPipeline.

        Show
        jira-bot ASF subversion and git services added a comment - Commit c17333621d5535e294f3122baa25dbdef8ab77dd in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c173336 ] SOLR-10174 : fix approx. 1 of 2 @Ignore-ed tests in TestLTRReRankingPipeline.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 58358099bf72b7d39bee2b67a57abdb7549787f8 in lucene-solr's branch refs/heads/master from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5835809 ]

        SOLR-10174, SOLR-11134: @AwaitsFix instead of @Ignore for TestLTRReRankingPipeline.testDifferentTopN

        Show
        jira-bot ASF subversion and git services added a comment - Commit 58358099bf72b7d39bee2b67a57abdb7549787f8 in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5835809 ] SOLR-10174 , SOLR-11134 : @AwaitsFix instead of @Ignore for TestLTRReRankingPipeline.testDifferentTopN
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 2f8b049019552c1e36e5845d6531d8376c79f49c in lucene-solr's branch refs/heads/branch_7x from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2f8b049 ]

        SOLR-10174: fix approx. 1 of 2 @Ignore-ed tests in TestLTRReRankingPipeline.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 2f8b049019552c1e36e5845d6531d8376c79f49c in lucene-solr's branch refs/heads/branch_7x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2f8b049 ] SOLR-10174 : fix approx. 1 of 2 @Ignore-ed tests in TestLTRReRankingPipeline.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 5be1258965c069b8c89c9a04b1f92fd218e027fe in lucene-solr's branch refs/heads/branch_7x from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5be1258 ]

        SOLR-10174, SOLR-11134: @AwaitsFix instead of @Ignore for TestLTRReRankingPipeline.testDifferentTopN

        Show
        jira-bot ASF subversion and git services added a comment - Commit 5be1258965c069b8c89c9a04b1f92fd218e027fe in lucene-solr's branch refs/heads/branch_7x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5be1258 ] SOLR-10174 , SOLR-11134 : @AwaitsFix instead of @Ignore for TestLTRReRankingPipeline.testDifferentTopN
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Bulk close after 7.1.0 release

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Bulk close after 7.1.0 release

          People

          • Assignee:
            cpoerschke Christine Poerschke
            Reporter:
            cpoerschke Christine Poerschke
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development