Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10147

Admin UI -> Cloud -> Graph: Impossible to see shard state

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.6, 7.0
    • Component/s: Admin UI
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      Currently in the Cloud -> Graph view there is a legend with color codes, but that is for replicas only.

      We need a way to quickly see the state of the shard, in particular if it is active or inactive. For testing, create a collection, then call SPLITSHARD on shard1, and you'll end up with shards shard1, shard1_0 and shard1_1. It is not possible to see which one is active or inactive.

      Also, the replicas belonging to the inactive shard are still marked with green "Active", while in reality they are "Inactive".

      The simplest would be to add a new state "Inactive" with color e.g. blue, which would be used on both shard and replica level. But since an inactive replica could also be "Gone" or "Down", there should be some way to indicate both at the same time...

      1. color_and_style.png
        37 kB
        Jan Høydahl
      2. screenshot-1.png
        125 kB
        Amrit Sarkar
      3. screenshot-2.png
        49 kB
        Amrit Sarkar
      4. screenshot-3.png
        76 kB
        Amrit Sarkar
      5. screenshot-4.png
        91 kB
        Amrit Sarkar
      6. screenshot-5.png
        74 kB
        Amrit Sarkar
      7. screenshot-6.png
        72 kB
        Amrit Sarkar
      8. screenshot-inactive-shard.png
        104 kB
        Amrit Sarkar
      9. SOLR-10147.patch
        6 kB
        Amrit Sarkar
      10. SOLR-10147.patch
        5 kB
        Amrit Sarkar
      11. SOLR-10147.patch
        5 kB
        Amrit Sarkar
      12. SOLR-10147-v1.patch
        5 kB
        Amrit Sarkar

        Issue Links

          Activity

          Hide
          sarkaramrit2@gmail.com Amrit Sarkar added a comment - - edited

          Mr. Høydahl,

          I like the idea of using color on shards, maybe "grey" for inactive and the default (empty circle) for the active shards but we can leave the replicas as it is. I completely understand that would be somehow not suited to the eyes, less human-readable but for an inactive shard, there will be a leader and the nodes will have their own state (active,down,recovering) which will not be serving requests.

          Let me know your thoughts, along with feedback from others, I would like to write the patch for this after we decide on what we need.

          Show
          sarkaramrit2@gmail.com Amrit Sarkar added a comment - - edited Mr. Høydahl, I like the idea of using color on shards, maybe "grey" for inactive and the default (empty circle) for the active shards but we can leave the replicas as it is. I completely understand that would be somehow not suited to the eyes, less human-readable but for an inactive shard, there will be a leader and the nodes will have their own state (active,down,recovering) which will not be serving requests. Let me know your thoughts, along with feedback from others, I would like to write the patch for this after we decide on what we need.
          Hide
          janhoy Jan Høydahl added a comment -

          I think grey for inactive shard may work. Feel free to cook up a patch and a screenshot, if no others have opinions.

          Show
          janhoy Jan Høydahl added a comment - I think grey for inactive shard may work. Feel free to cook up a patch and a screenshot, if no others have opinions.
          Hide
          sarkaramrit2@gmail.com Amrit Sarkar added a comment - - edited

          Mr. Høydahl

          SOLR-10147.patch is first draft for what we are trying to achieve here. I made changes in existing CSS as 'grey' color is very fine and both 'Inactive' and 'Gone' were almost identical. Made 'Gone' more lighter.

          modified: webapp/web/css/angular/cloud.css
          modified: webapp/web/js/angular/controllers/cloud.js
          modified: webapp/web/partials/cloud.html

          Screenshot is attached, color combination is to be decided, whether this is good enough or we need to tweak the hex color code more.

          Show
          sarkaramrit2@gmail.com Amrit Sarkar added a comment - - edited Mr. Høydahl SOLR-10147 .patch is first draft for what we are trying to achieve here. I made changes in existing CSS as 'grey' color is very fine and both 'Inactive' and 'Gone' were almost identical. Made 'Gone' more lighter. modified: webapp/web/css/angular/cloud.css modified: webapp/web/js/angular/controllers/cloud.js modified: webapp/web/partials/cloud.html Screenshot is attached, color combination is to be decided, whether this is good enough or we need to tweak the hex color code more.
          Hide
          janhoy Jan Høydahl added a comment -

          i like it, but will let Upayavira and others who can speak for consistency in colors etc have a say.
          In your patch you set replica states to "Inactive" unless the node is "gone". Will a replica for an inactive shard never be "Recovering" or "Down"?

          Show
          janhoy Jan Høydahl added a comment - i like it, but will let Upayavira and others who can speak for consistency in colors etc have a say. In your patch you set replica states to "Inactive" unless the node is "gone". Will a replica for an inactive shard never be "Recovering" or "Down"?
          Hide
          sarkaramrit2@gmail.com Amrit Sarkar added a comment - - edited

          Mr. Høydahl,

          Ah, how did I miss that!. Kindly provide your suggestion on how to design this: probably 'grey' for replica, when shard is inactive and replica is active, and rest for replicas, everything as it is?

          Patch uploaded for the same.

          Show
          sarkaramrit2@gmail.com Amrit Sarkar added a comment - - edited Mr. Høydahl, Ah, how did I miss that!. Kindly provide your suggestion on how to design this: probably 'grey' for replica, when shard is inactive and replica is active, and rest for replicas, everything as it is? Patch uploaded for the same.
          Hide
          janhoy Jan Høydahl added a comment - - edited

          I'm not sure it is even important to distinguish between various states of an inactive shard/replica? We could use italics or bold, or even strikethrough in order to not being dependent on colors. BTW, it is bad practice to rely on colors only, ref color blind people or if you print the page on a B/W printer

          So to try to improve on the existing states as well, what if we create a scheme with combinations of color and style, here is an attempt where we use bold to signify Leader, italic to mean recovering and strike-through means inactive, while double strikethrough means Gone. See screen shot:

          http://jsfiddle.net/janhoy/w4Ldbhy7/4/

          Show
          janhoy Jan Høydahl added a comment - - edited I'm not sure it is even important to distinguish between various states of an inactive shard/replica? We could use italics or bold , or even strikethrough in order to not being dependent on colors. BTW, it is bad practice to rely on colors only, ref color blind people or if you print the page on a B/W printer So to try to improve on the existing states as well, what if we create a scheme with combinations of color and style, here is an attempt where we use bold to signify Leader, italic to mean recovering and strike-through means inactive, while double strikethrough means Gone. See screen shot: http://jsfiddle.net/janhoy/w4Ldbhy7/4/
          Hide
          sarkaramrit2@gmail.com Amrit Sarkar added a comment -

          Loved it. This makes much more sense. I tried to cook up a patch for the same and following are the observations:

          1. Getting leader replica 'bold' is apt, but we can stick to 'green' as it is more soothing to the eyes to be honest.
          PF screenshot-2 and screenshot-3
          2. Double striking 'Gone' is making it difficult to read. If a node is gone, it should be in readable format for the user to pay attention, with double strike it looked messy.
          3. _italics_for 'Recovery' and 'Recovery failed' stands out.
          PF screenshot-4
          4. Striking 'inactive' both replicas and shard are apt. On screen, it is likeable.

          I have uploaded a patch 'SOLR-10147-v1.patch' considering the following for now:
          1. Bold for Leader, color still 'green'.
          2. Line-through for Inactive nodes and shard (no matter what condition it is).
          3. italics for 'Recovery' and 'Recovery failed'.
          3. Added Legend 'Inactive'.

          PF screenshot-5 and screenshot-6

          Let me know your thoughts on this.

          Show
          sarkaramrit2@gmail.com Amrit Sarkar added a comment - Loved it. This makes much more sense. I tried to cook up a patch for the same and following are the observations: 1. Getting leader replica 'bold' is apt, but we can stick to 'green' as it is more soothing to the eyes to be honest. PF screenshot-2 and screenshot-3 2. Double striking 'Gone' is making it difficult to read. If a node is gone, it should be in readable format for the user to pay attention, with double strike it looked messy. 3. _italics_for 'Recovery' and 'Recovery failed' stands out. PF screenshot-4 4. Striking 'inactive' both replicas and shard are apt. On screen, it is likeable. I have uploaded a patch ' SOLR-10147 -v1.patch' considering the following for now: 1. Bold for Leader, color still 'green'. 2. Line-through for Inactive nodes and shard (no matter what condition it is). 3. italics for 'Recovery' and 'Recovery failed'. 3. Added Legend ' Inactive '. PF screenshot-5 and screenshot-6 Let me know your thoughts on this.
          Hide
          janhoy Jan Høydahl added a comment -

          +1

          Show
          janhoy Jan Høydahl added a comment - +1
          Hide
          sarkaramrit2@gmail.com Amrit Sarkar added a comment -

          Glad you found it useful.

          Show
          sarkaramrit2@gmail.com Amrit Sarkar added a comment - Glad you found it useful.
          Hide
          sarkaramrit2@gmail.com Amrit Sarkar added a comment -

          Jan, following up on issue. Are we planning to roll out this in 6.5? If not, can you let me know what we can do to improve this.

          Show
          sarkaramrit2@gmail.com Amrit Sarkar added a comment - Jan, following up on issue. Are we planning to roll out this in 6.5? If not, can you let me know what we can do to improve this.
          Hide
          janhoy Jan Høydahl added a comment -

          Hi, can please another committer who cares for look and feel chime in here?
          The strike-through effect is a bit hard to see on the shard level since there is (often) another line also cutting through the text. Except for that I'm ready to commit.

          Show
          janhoy Jan Høydahl added a comment - Hi, can please another committer who cares for look and feel chime in here? The strike-through effect is a bit hard to see on the shard level since there is (often) another line also cutting through the text. Except for that I'm ready to commit.
          Hide
          sarkaramrit2@gmail.com Amrit Sarkar added a comment -

          The strike-through effect is a bit hard to see on the shard level since there is (often) another line also cutting through the text

          That is true, I tried hard to make the path-lines as light as possible. Let me play around with line-through and see if there is any alternative.

          Show
          sarkaramrit2@gmail.com Amrit Sarkar added a comment - The strike-through effect is a bit hard to see on the shard level since there is (often) another line also cutting through the text That is true, I tried hard to make the path-lines as light as possible. Let me play around with line-through and see if there is any alternative.
          Hide
          janhoy Jan Høydahl added a comment -

          Amrit Sarkar dit you get any further? Guess we could overlay a line-through with another color and/or thickness, or we could apply a background color/image or add plain-text (inactive) as a suffix...

          Show
          janhoy Jan Høydahl added a comment - Amrit Sarkar dit you get any further? Guess we could overlay a line-through with another color and/or thickness, or we could apply a background color/image or add plain-text (inactive) as a suffix...
          Hide
          sarkaramrit2@gmail.com Amrit Sarkar added a comment - - edited

          Jan Høydahl not really, I tried a bunch of things but I am not great with CSS. I referred this: http://stackoverflow.com/questions/2539207/how-to-change-the-strike-out-line-through-thickness-in-css and bunch of other helping CSS links but it is just not recognising this CSS on those particular element. Some type of overriding hierarchy which I did't had chance to play along.

          We can add background color/image in CSS or (inactive) as suffix easily in JS though. Adding plain text will be much more simple and informative than giving special background. Let me know your thoughts.

          Show
          sarkaramrit2@gmail.com Amrit Sarkar added a comment - - edited Jan Høydahl not really, I tried a bunch of things but I am not great with CSS. I referred this: http://stackoverflow.com/questions/2539207/how-to-change-the-strike-out-line-through-thickness-in-css and bunch of other helping CSS links but it is just not recognising this CSS on those particular element. Some type of overriding hierarchy which I did't had chance to play along. We can add background color/image in CSS or (inactive) as suffix easily in JS though. Adding plain text will be much more simple and informative than giving special background. Let me know your thoughts.
          Hide
          janhoy Jan Høydahl added a comment -

          Perhaps plain text in addition to the current strike through? And then get this committed

          Show
          janhoy Jan Høydahl added a comment - Perhaps plain text in addition to the current strike through? And then get this committed
          Hide
          sarkaramrit2@gmail.com Amrit Sarkar added a comment -

          Roger that

          PF SOLR-10147.patch with plain text (inactive) besides the shard name. PF screenshot-inactive-shard.png.

          Show
          sarkaramrit2@gmail.com Amrit Sarkar added a comment - Roger that PF SOLR-10147 .patch with plain text (inactive) besides the shard name. PF screenshot-inactive-shard.png.
          Hide
          janhoy Jan Høydahl added a comment -

          OK, will commit very soon if no objections but it will not make it in 6.5 so it will go in master and branch_6x

          Show
          janhoy Jan Høydahl added a comment - OK, will commit very soon if no objections but it will not make it in 6.5 so it will go in master and branch_6x
          Hide
          sarkaramrit2@gmail.com Amrit Sarkar added a comment -

          Jan Høydahl whatever feels best, I am glad this helped the use case.

          Show
          sarkaramrit2@gmail.com Amrit Sarkar added a comment - Jan Høydahl whatever feels best, I am glad this helped the use case.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit a6f27d3e1e457f9bc3bd4b9afcacfc37e9a87e80 in lucene-solr's branch refs/heads/master from Jan Høydahl
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a6f27d3 ]

          SOLR-10147: Admin UI -> Cloud -> Graph: Impossible to see shard state

          Show
          jira-bot ASF subversion and git services added a comment - Commit a6f27d3e1e457f9bc3bd4b9afcacfc37e9a87e80 in lucene-solr's branch refs/heads/master from Jan Høydahl [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a6f27d3 ] SOLR-10147 : Admin UI -> Cloud -> Graph: Impossible to see shard state
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit bb5454c4a945eafb9f795fd501c6d5932916d8c0 in lucene-solr's branch refs/heads/branch_6x from Jan Høydahl
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=bb5454c ]

          SOLR-10147: Admin UI -> Cloud -> Graph: Impossible to see shard state

          (cherry picked from commit a6f27d3)

          Show
          jira-bot ASF subversion and git services added a comment - Commit bb5454c4a945eafb9f795fd501c6d5932916d8c0 in lucene-solr's branch refs/heads/branch_6x from Jan Høydahl [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=bb5454c ] SOLR-10147 : Admin UI -> Cloud -> Graph: Impossible to see shard state (cherry picked from commit a6f27d3)

            People

            • Assignee:
              janhoy Jan Høydahl
              Reporter:
              janhoy Jan Høydahl
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development