Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.5, 7.0
    • Component/s: Admin UI
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      Currently you can delete a replica through a small red X in the Admin UI Collections tab. So you can delete all the replicas inside a shard, but you cannot delete the whole shard, i.e. call the DELETESHARD Collection API.

      Add a button for this. This is useful for cleaning up e.g. after calling SPLITSHARD.

      1. Screenshot-1.png
        108 kB
        Amrit Sarkar
      2. Screenshot-2.png
        119 kB
        Amrit Sarkar
      3. SOLR-10146.patch
        5 kB
        Jan Høydahl
      4. SOLR-10146.patch
        4 kB
        Amrit Sarkar

        Issue Links

          Activity

          Hide
          sarkaramrit2@gmail.com Amrit Sarkar added a comment - - edited

          Mr. Høydahl,

          SOLR-10146.patch is uploaded incorporating delete (X) button alongside the shard name in http://[solr-host]:[solr-port]/solr/#/~collections/[collection-name]
          [Screenshot-1]

          Changes made in:
          1. solr/webapp/web/css/angular/collections.css
          2. solr/webapp/web/js/angular/controllers/collections.js
          3. solr/webapp/web/js/angular/services.js
          4. solr/webapp/web/partials/collections.html

          As you are aware, a shard cannot be deleted when it is active, hence it will throw error if we try to do so.
          [Screenshot-2]

          Let me know if this suffice the use-case here.

          Show
          sarkaramrit2@gmail.com Amrit Sarkar added a comment - - edited Mr. Høydahl, SOLR-10146 .patch is uploaded incorporating delete (X) button alongside the shard name in http://[solr-host]:[solr-port]/solr/#/~collections/[collection-name ] [Screenshot-1] Changes made in: 1. solr/webapp/web/css/angular/collections.css 2. solr/webapp/web/js/angular/controllers/collections.js 3. solr/webapp/web/js/angular/services.js 4. solr/webapp/web/partials/collections.html As you are aware, a shard cannot be deleted when it is active, hence it will throw error if we try to do so. [Screenshot-2] Let me know if this suffice the use-case here.
          Hide
          sarkaramrit2@gmail.com Amrit Sarkar added a comment -

          Jan Høydahl

          Let me know your thoughts on this one too. Personally I would like the dialog boxes to poped up, getting the background black/inactive whenever we are trying to add/edit/delete replica/shard/collection.

          Show
          sarkaramrit2@gmail.com Amrit Sarkar added a comment - Jan Høydahl Let me know your thoughts on this one too. Personally I would like the dialog boxes to poped up, getting the background black/inactive whenever we are trying to add/edit/delete replica/shard/collection.
          Hide
          sarkaramrit2@gmail.com Amrit Sarkar added a comment -

          Created new jira: SOLR-10209 to track the developments, suggestions and feedbacks. Thank you.

          Show
          sarkaramrit2@gmail.com Amrit Sarkar added a comment - Created new jira: SOLR-10209 to track the developments, suggestions and feedbacks. Thank you.
          Hide
          sarkaramrit2@gmail.com Amrit Sarkar added a comment -

          Jan, following up on issue. Are we planning to roll out this in 6.5? If not, can you let me know what we can do to improve this.

          Show
          sarkaramrit2@gmail.com Amrit Sarkar added a comment - Jan, following up on issue. Are we planning to roll out this in 6.5? If not, can you let me know what we can do to improve this.
          Hide
          janhoy Jan Høydahl added a comment -

          Sorry for the lack of feedback.

          Attached is a new patch

          • Only display delete button if shard is inactive or uses implicit routing. This keeps UI cleaner since there is no point in trying an action that will never succeed.
          • Added CHANGES entry

          I'll commit this next week if everybody happy clappy

          PS: In order to test, I created three collections, one plain, one where I split a shard to get an inactive one, and a third with implicit routing. Only the implicit shards and the inactive were showing the button.

          Show
          janhoy Jan Høydahl added a comment - Sorry for the lack of feedback. Attached is a new patch Only display delete button if shard is inactive or uses implicit routing. This keeps UI cleaner since there is no point in trying an action that will never succeed. Added CHANGES entry I'll commit this next week if everybody happy clappy PS: In order to test, I created three collections, one plain, one where I split a shard to get an inactive one, and a third with implicit routing. Only the implicit shards and the inactive were showing the button.
          Hide
          sarkaramrit2@gmail.com Amrit Sarkar added a comment -

          Clean! Thanks for considering the patch, feedback and making the necessary changes, makes much more sense.

          Show
          sarkaramrit2@gmail.com Amrit Sarkar added a comment - Clean! Thanks for considering the patch, feedback and making the necessary changes, makes much more sense.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit eba216f45ceeef1666da1af45d8eb724d291a6f7 in lucene-solr's branch refs/heads/branch_6x from Jan Høydahl
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=eba216f ]

          SOLR-10146: Added button to the Admin UI 'Collection' tab for deleting an inactive shard

          (cherry picked from commit b2dcb47)

          Show
          jira-bot ASF subversion and git services added a comment - Commit eba216f45ceeef1666da1af45d8eb724d291a6f7 in lucene-solr's branch refs/heads/branch_6x from Jan Høydahl [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=eba216f ] SOLR-10146 : Added button to the Admin UI 'Collection' tab for deleting an inactive shard (cherry picked from commit b2dcb47)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit b2dcb47ef44a814c670b5cf2a53c0d6c52810d84 in lucene-solr's branch refs/heads/master from Jan Høydahl
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b2dcb47 ]

          SOLR-10146: Added button to the Admin UI 'Collection' tab for deleting an inactive shard

          Show
          jira-bot ASF subversion and git services added a comment - Commit b2dcb47ef44a814c670b5cf2a53c0d6c52810d84 in lucene-solr's branch refs/heads/master from Jan Høydahl [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b2dcb47 ] SOLR-10146 : Added button to the Admin UI 'Collection' tab for deleting an inactive shard
          Hide
          janhoy Jan Høydahl added a comment -

          Pushed this. Appreciate if someone takes it for a spin just for safes, since there are no unit tests for the UI.

          Show
          janhoy Jan Høydahl added a comment - Pushed this. Appreciate if someone takes it for a spin just for safes, since there are no unit tests for the UI.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f49bd79ec14f58361320a0931a936840cb15df86 in lucene-solr's branch refs/heads/master from Mikhail Khludnev
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f49bd79 ]

          SOLR-10146: fixing tabs

          Show
          jira-bot ASF subversion and git services added a comment - Commit f49bd79ec14f58361320a0931a936840cb15df86 in lucene-solr's branch refs/heads/master from Mikhail Khludnev [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f49bd79 ] SOLR-10146 : fixing tabs
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 4d107caa8d982085d7ca52b7322100f8f088b544 in lucene-solr's branch refs/heads/branch_6x from Mikhail Khludnev
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4d107ca ]

          SOLR-10146: fixing tabs

          Show
          jira-bot ASF subversion and git services added a comment - Commit 4d107caa8d982085d7ca52b7322100f8f088b544 in lucene-solr's branch refs/heads/branch_6x from Mikhail Khludnev [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4d107ca ] SOLR-10146 : fixing tabs
          Hide
          janhoy Jan Høydahl added a comment -

          Ah, thanks Mikhail Khludnev!

          Show
          janhoy Jan Høydahl added a comment - Ah, thanks Mikhail Khludnev !
          Hide
          mkhludnev Mikhail Khludnev added a comment -

          Jan Høydahl, you are welcome!

          Show
          mkhludnev Mikhail Khludnev added a comment - Jan Høydahl , you are welcome!

            People

            • Assignee:
              janhoy Jan Høydahl
              Reporter:
              janhoy Jan Høydahl
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development