Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10138

Transaction log replay can hit an NPE due to new Metrics code.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.4.2, 6.5, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None
    1. SOLR-10138.patch
      1 kB
      Andrzej Bialecki

      Issue Links

        Activity

        Hide
        markrmiller@gmail.com Mark Miller added a comment -
           [junit4]   2> java.lang.NullPointerException
           [junit4]   2> 	at org.apache.solr.update.UpdateLog$LogReplayer.doReplay(UpdateLog.java:1671)
           [junit4]   2> 	at org.apache.solr.update.UpdateLog$LogReplayer.run(UpdateLog.java:1510)
           [junit4]   2> 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
           [junit4]   2> 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
           [junit4]   2> 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
           [junit4]   2> 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
           [junit4]   2> 	at org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor.lambda$execute$0(ExecutorUtil.java:229)
           [junit4]   2> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
           [junit4]   2> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
           [junit4]   2> 	at java.lang.Thread.run(Thread.java:745)
        
                    if (state == State.REPLAYING) {
                      replayOpsMeter.mark();
        
        Show
        markrmiller@gmail.com Mark Miller added a comment - [junit4] 2> java.lang.NullPointerException [junit4] 2> at org.apache.solr.update.UpdateLog$LogReplayer.doReplay(UpdateLog.java:1671) [junit4] 2> at org.apache.solr.update.UpdateLog$LogReplayer.run(UpdateLog.java:1510) [junit4] 2> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [junit4] 2> at java.util.concurrent.FutureTask.run(FutureTask.java:266) [junit4] 2> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [junit4] 2> at java.util.concurrent.FutureTask.run(FutureTask.java:266) [junit4] 2> at org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor.lambda$execute$0(ExecutorUtil.java:229) [junit4] 2> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [junit4] 2> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [junit4] 2> at java.lang.Thread.run(Thread.java:745) if (state == State.REPLAYING) { replayOpsMeter.mark();
        Hide
        ab Andrzej Bialecki added a comment -

        This is because HdfsUpdateLog.init(UpdateHandler, SolrCore) doesn't call super, so it doesn't register metrics instances either. The fix is to simply add this registration, like it's done in UpdateLog:362. I'll fix this shortly.

        Show
        ab Andrzej Bialecki added a comment - This is because HdfsUpdateLog.init(UpdateHandler, SolrCore) doesn't call super, so it doesn't register metrics instances either. The fix is to simply add this registration, like it's done in UpdateLog:362 . I'll fix this shortly.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit f51253a331fb938fd92eab4dab60df380d6837b8 in lucene-solr's branch refs/heads/master from Andrzej Bialecki
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f51253a ]

        SOLR-10138: Transaction log replay can hit an NPE due to new Metrics code.

        Show
        jira-bot ASF subversion and git services added a comment - Commit f51253a331fb938fd92eab4dab60df380d6837b8 in lucene-solr's branch refs/heads/master from Andrzej Bialecki [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f51253a ] SOLR-10138 : Transaction log replay can hit an NPE due to new Metrics code.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 94a4b3de59ccb73d7568a154c19316181c973baf in lucene-solr's branch refs/heads/branch_6x from Andrzej Bialecki
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=94a4b3d ]

        SOLR-10138: Transaction log replay can hit an NPE due to new Metrics code.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 94a4b3de59ccb73d7568a154c19316181c973baf in lucene-solr's branch refs/heads/branch_6x from Andrzej Bialecki [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=94a4b3d ] SOLR-10138 : Transaction log replay can hit an NPE due to new Metrics code.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ed60e849964e0868496c045f4ce1e1b35e9c7279 in lucene-solr's branch refs/heads/branch_6_4 from Andrzej Bialecki
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ed60e84 ]

        SOLR-10138: Transaction log replay can hit an NPE due to new Metrics code.

        Show
        jira-bot ASF subversion and git services added a comment - Commit ed60e849964e0868496c045f4ce1e1b35e9c7279 in lucene-solr's branch refs/heads/branch_6_4 from Andrzej Bialecki [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ed60e84 ] SOLR-10138 : Transaction log replay can hit an NPE due to new Metrics code.

          People

          • Assignee:
            ab Andrzej Bialecki
            Reporter:
            markrmiller@gmail.com Mark Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development