Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10120

A SolrCore reload can remove the index from the previous SolrCore during replication index rollover.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.5, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Issue Links

        Activity

        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        This patch will only allow one core reload at a time and reload index cleanup will leave the most recent index.

        Show
        markrmiller@gmail.com Mark Miller added a comment - This patch will only allow one core reload at a time and reload index cleanup will leave the most recent index.
        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        I suppose we could also do cleanup on core shutdown and keep the time the old directory is around to a minimum.

        Show
        markrmiller@gmail.com Mark Miller added a comment - I suppose we could also do cleanup on core shutdown and keep the time the old directory is around to a minimum.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 2196663156d2d72bc61e72c296a2c778754f881f in lucene-solr's branch refs/heads/master from markrmiller
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2196663 ]

        SOLR-10120: A SolrCore reload can remove the index from the previous SolrCore during replication index rollover.
        SOLR-10124: Replication can skip removing a temporary index directory in some cases when it should not.
        SOLR-10119: Harden TestReplicationHandler.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 2196663156d2d72bc61e72c296a2c778754f881f in lucene-solr's branch refs/heads/master from markrmiller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2196663 ] SOLR-10120 : A SolrCore reload can remove the index from the previous SolrCore during replication index rollover. SOLR-10124 : Replication can skip removing a temporary index directory in some cases when it should not. SOLR-10119 : Harden TestReplicationHandler.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 53beb4989e2acaf111c00f59d57f7812a88e3a2f in lucene-solr's branch refs/heads/branch_6x from markrmiller
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=53beb49 ]

        SOLR-10120: A SolrCore reload can remove the index from the previous SolrCore during replication index rollover.
        SOLR-10124: Replication can skip removing a temporary index directory in some cases when it should not.
        SOLR-10119: Harden TestReplicationHandler.

        1. Conflicts:
        2. solr/CHANGES.txt
        3. solr/core/src/java/org/apache/solr/core/SolrCore.java
        4. solr/core/src/java/org/apache/solr/handler/IndexFetcher.java
        5. solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java
        Show
        jira-bot ASF subversion and git services added a comment - Commit 53beb4989e2acaf111c00f59d57f7812a88e3a2f in lucene-solr's branch refs/heads/branch_6x from markrmiller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=53beb49 ] SOLR-10120 : A SolrCore reload can remove the index from the previous SolrCore during replication index rollover. SOLR-10124 : Replication can skip removing a temporary index directory in some cases when it should not. SOLR-10119 : Harden TestReplicationHandler. Conflicts: solr/CHANGES.txt solr/core/src/java/org/apache/solr/core/SolrCore.java solr/core/src/java/org/apache/solr/handler/IndexFetcher.java solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 19c8ec2bf1882bed1bb34d0b55198d03f2018838 in lucene-solr's branch refs/heads/master from markrmiller
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=19c8ec2 ]

        SOLR-10120: Clean up earlier so we don't hit closed resources.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 19c8ec2bf1882bed1bb34d0b55198d03f2018838 in lucene-solr's branch refs/heads/master from markrmiller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=19c8ec2 ] SOLR-10120 : Clean up earlier so we don't hit closed resources.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit cbf0f8383b10fee0583e2b50188979b8a0583dc8 in lucene-solr's branch refs/heads/master from Cao Manh Dat
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cbf0f83 ]

        SOLR-10120: Convert/migrate tests using EasyMock to Mockito

        Show
        jira-bot ASF subversion and git services added a comment - Commit cbf0f8383b10fee0583e2b50188979b8a0583dc8 in lucene-solr's branch refs/heads/master from Cao Manh Dat [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cbf0f83 ] SOLR-10120 : Convert/migrate tests using EasyMock to Mockito
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1df02f0bcb0c03f2337d1d44489080ba99217f4b in lucene-solr's branch refs/heads/branch_6x from markrmiller
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1df02f0 ]

        SOLR-10120: Clean up earlier so we don't hit closed resources.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1df02f0bcb0c03f2337d1d44489080ba99217f4b in lucene-solr's branch refs/heads/branch_6x from markrmiller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1df02f0 ] SOLR-10120 : Clean up earlier so we don't hit closed resources.
        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        I think there is an issue with the index cleanup test after this. I need to investigate.

        Show
        markrmiller@gmail.com Mark Miller added a comment - I think there is an issue with the index cleanup test after this. I need to investigate.
        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        Nope, seems the CleanupOldIndexTest fails are not related to this issue.

        Show
        markrmiller@gmail.com Mark Miller added a comment - Nope, seems the CleanupOldIndexTest fails are not related to this issue.

          People

          • Assignee:
            markrmiller@gmail.com Mark Miller
            Reporter:
            markrmiller@gmail.com Mark Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development