Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10077

TestManagedFeatureStore extends LuceneTestCase, but has no tests and just hosts a static method.

    Details

    • Type: Test
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.5, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      We should probably just put this static method somewhere else?

      1. SOLR-10077.patch
        12 kB
        Christine Poerschke

        Issue Links

          Activity

          Show
          cpoerschke Christine Poerschke added a comment - https://github.com/apache/lucene-solr/blob/master/solr/contrib/ltr/src/test/org/apache/solr/ltr/store/rest/TestManagedFeatureStore.java
          Hide
          cpoerschke Christine Poerschke added a comment -

          Attached patch proposes to merge TestFeatureStore and TestFeatureLtrScoringModel into TestManagedFeatureStore.

          Extra context info as to the reason for the ticket here:

          • the TestManagedFeatureStore.java file name follows the TestMyClass.java or MyClassTest.java naming convention (and the class extends LuceneTestCase)
          • running ant test -Dtestcase=TestManagedFeatureStore however fails since there are no tests:

            BUILD FAILED ... Not even a single test was executed (a typo in the filter pattern maybe?). ...

          Show
          cpoerschke Christine Poerschke added a comment - Attached patch proposes to merge TestFeatureStore and TestFeatureLtrScoringModel into TestManagedFeatureStore. Extra context info as to the reason for the ticket here: the TestManagedFeatureStore.java file name follows the TestMyClass.java or MyClassTest.java naming convention (and the class extends LuceneTestCase) running ant test -Dtestcase=TestManagedFeatureStore however fails since there are no tests: BUILD FAILED ... Not even a single test was executed (a typo in the filter pattern maybe?). ...
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f47bbb35ae7821171038e058a089a49598bdb8f2 in lucene-solr's branch refs/heads/master from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f47bbb3 ]

          SOLR-10077: merge TestFeatureStore and TestFeatureLtrScoringModel into TestManagedFeatureStore.

          Show
          jira-bot ASF subversion and git services added a comment - Commit f47bbb35ae7821171038e058a089a49598bdb8f2 in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f47bbb3 ] SOLR-10077 : merge TestFeatureStore and TestFeatureLtrScoringModel into TestManagedFeatureStore.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit a22681c8594cd9b97bc6d013acb0bdf61835d2a0 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a22681c ]

          SOLR-10077: merge TestFeatureStore and TestFeatureLtrScoringModel into TestManagedFeatureStore.

          Show
          jira-bot ASF subversion and git services added a comment - Commit a22681c8594cd9b97bc6d013acb0bdf61835d2a0 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a22681c ] SOLR-10077 : merge TestFeatureStore and TestFeatureLtrScoringModel into TestManagedFeatureStore.

            People

            • Assignee:
              cpoerschke Christine Poerschke
              Reporter:
              markrmiller@gmail.com Mark Miller
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development