Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0
    • Component/s: Admin UI
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      The old jQuery based Admin UI has been deprecated since 6.0. Let us clean up the last known bugs in Angular UI and simply delete the old UI in master.

      1. SOLR-10042_remove_commented.patch
        20 kB
        Jan Høydahl
      2. SOLR-10042.patch
        1.53 MB
        Jan Høydahl

        Issue Links

          Activity

          Hide
          arafalov Alexandre Rafalovitch added a comment -

          Should we use this one as a umbrella issue and link open UI bugs into it?

          Show
          arafalov Alexandre Rafalovitch added a comment - Should we use this one as a umbrella issue and link open UI bugs into it?
          Hide
          janhoy Jan Høydahl added a comment -

          Feel free And then before closing this and releasing 7.0 we decide whether remaining liked issues are blockers or not.

          Show
          janhoy Jan Høydahl added a comment - Feel free And then before closing this and releasing 7.0 we decide whether remaining liked issues are blockers or not.
          Hide
          janhoy Jan Høydahl added a comment -

          Linking some Angular UI bugs as "requires". I don't mean that all of these need to be fixed before we kill the old UI, but probably some of them should. We can discuss that further here and then attempt fixing the most serious ones before deleting the old UI code.

          Show
          janhoy Jan Høydahl added a comment - Linking some Angular UI bugs as "requires". I don't mean that all of these need to be fixed before we kill the old UI, but probably some of them should. We can discuss that further here and then attempt fixing the most serious ones before deleting the old UI code.
          Hide
          janhoy Jan Høydahl added a comment -

          First patch that rips out old Admin UI and also removes the non-working "Dump" feature (SOLR-8982)

          I fixed SOLR-8149. None of the other UI issues I've linked here is critical to fix. But I recall there may be some other issue that is a blocker? Can't find it right now.

          Show
          janhoy Jan Høydahl added a comment - First patch that rips out old Admin UI and also removes the non-working "Dump" feature ( SOLR-8982 ) I fixed SOLR-8149 . None of the other UI issues I've linked here is critical to fix. But I recall there may be some other issue that is a blocker? Can't find it right now.
          Hide
          janhoy Jan Høydahl added a comment -

          The blocker issue I was thinking about was SOLR-9516 which is now resolved. So can someone please review my patch. What it does is basically:

          • Delete webapp/web/css/styles
          • Delete webapp/web/css/chosen.css
          • Delete webapp/web/js/lib
          • Delete webapp/web/js/scripts
          • Delete webapp/web/js/main.js
          • Delete webapp/web/js/require.js
          • Delete webapp/web/tpl
          • Delete webapp/web/old.html
          • Switches velocity code from js/lib/jquery-1.7.2.min.js to /libs/jquery-2.1.3.min.js (not tested)
          • Remove javacscript-natural-sort-NOTICE.txt and license
          • Rips out "Dump" feature and removes ZeroClipboard from wherever, inlcuding NOTICE.txt
          • Moves java-properties.css from styles/ to angular/
          • Removes link to old UI in index.html

          The patch works without breaking anything as far I can tell, but I may have overlooked some file or deleted too much without knowing, please speak out.

          Show
          janhoy Jan Høydahl added a comment - The blocker issue I was thinking about was SOLR-9516 which is now resolved. So can someone please review my patch. What it does is basically: Delete webapp/web/css/styles Delete webapp/web/css/chosen.css Delete webapp/web/js/lib Delete webapp/web/js/scripts Delete webapp/web/js/main.js Delete webapp/web/js/require.js Delete webapp/web/tpl Delete webapp/web/old.html Switches velocity code from js/lib/jquery-1.7.2.min.js to /libs/jquery-2.1.3.min.js (not tested) Remove javacscript-natural-sort-NOTICE.txt and license Rips out "Dump" feature and removes ZeroClipboard from wherever, inlcuding NOTICE.txt Moves java-properties.css from styles/ to angular/ Removes link to old UI in index.html The patch works without breaking anything as far I can tell, but I may have overlooked some file or deleted too much without knowing, please speak out.
          Hide
          janhoy Jan Høydahl added a comment -

          Calling out to Upayavira and Stefan Matheis (steffkes), does this patch seem viable?
          Are you aware of any other open JIRA that should be a blocker for committing this?
          If I don't hear anything I'll commit current patch to master on thursday.

          Show
          janhoy Jan Høydahl added a comment - Calling out to Upayavira and Stefan Matheis (steffkes) , does this patch seem viable? Are you aware of any other open JIRA that should be a blocker for committing this? If I don't hear anything I'll commit current patch to master on thursday.
          Hide
          steffkes Stefan Matheis (steffkes) added a comment -

          Jan Høydahl LGTM. as far as i know the structure is pretty well separated between the old and the current UI, so it should be okay to remove all the old files, yepp

          Show
          steffkes Stefan Matheis (steffkes) added a comment - Jan Høydahl LGTM. as far as i know the structure is pretty well separated between the old and the current UI, so it should be okay to remove all the old files, yepp
          Hide
          janhoy Jan Høydahl added a comment -

          Anyone remember what the commented-out lines in app.js is about? See https://github.com/apache/lucene-solr/blob/e2521b2a8baabdaf43b92192588f51e042d21e97/solr/webapp/web/js/angular/app.js#L551

          Does it have a JIRA issue or is not necessary?

          Show
          janhoy Jan Høydahl added a comment - Anyone remember what the commented-out lines in app.js is about? See https://github.com/apache/lucene-solr/blob/e2521b2a8baabdaf43b92192588f51e042d21e97/solr/webapp/web/js/angular/app.js#L551 Does it have a JIRA issue or is not necessary?
          Hide
          janhoy Jan Høydahl added a comment - - edited

          Found one showstopper - the autocomplete plugin used by velocity requires an older version of jquery.
          I'm including both jquery 1.7.2 and 2.1.3 in webapp/web/libs for now. Opened SOLR-10705 to remember to migrate Velocity to newer jquery later.

          Show
          janhoy Jan Høydahl added a comment - - edited Found one showstopper - the autocomplete plugin used by velocity requires an older version of jquery. I'm including both jquery 1.7.2 and 2.1.3 in webapp/web/libs for now. Opened SOLR-10705 to remember to migrate Velocity to newer jquery later.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 21384b5b215a68233cb3ef9edaea14be935570b9 in lucene-solr's branch refs/heads/master from Jan Høydahl
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=21384b5 ]

          SOLR-10042: Delete old deprecated Admin UI

          Show
          jira-bot ASF subversion and git services added a comment - Commit 21384b5b215a68233cb3ef9edaea14be935570b9 in lucene-solr's branch refs/heads/master from Jan Høydahl [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=21384b5 ] SOLR-10042 : Delete old deprecated Admin UI
          Hide
          janhoy Jan Høydahl added a comment -

          This is now in master branch. Yey!!

          Please test it out locally and fool around in the Admin UI to see if you find anything that is broken, or perhaps any dead files.

          Also, please continue to fix the remaining minor issues listed as dependencies.

          Show
          janhoy Jan Høydahl added a comment - This is now in master branch. Yey!! Please test it out locally and fool around in the Admin UI to see if you find anything that is broken, or perhaps any dead files. Also, please continue to fix the remaining minor issues listed as dependencies.
          Hide
          arafalov Alexandre Rafalovitch added a comment -

          I think the commented out part was the unimplemented features. But some of them got implemented later through their own JIRAs. I think it is safe to not worry about it and just let people report the issues found normally.

          Show
          arafalov Alexandre Rafalovitch added a comment - I think the commented out part was the unimplemented features. But some of them got implemented later through their own JIRAs. I think it is safe to not worry about it and just let people report the issues found normally.
          Hide
          janhoy Jan Høydahl added a comment -

          Thanks Alexandre Rafalovitch. Attaching a proposed patch SOLR-10042_remove_commented.patch that removes large comment blocks in several files. Do you see anything in there that I should NOT delete? If not, I'll commit this patch as well.

          Show
          janhoy Jan Høydahl added a comment - Thanks Alexandre Rafalovitch . Attaching a proposed patch SOLR-10042 _remove_commented.patch that removes large comment blocks in several files. Do you see anything in there that I should NOT delete? If not, I'll commit this patch as well.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d30d012c7c2f9de46a32d7e9eda3b17c51a7fa04 in lucene-solr's branch refs/heads/master from Tomas Fernandez Lobbe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d30d012 ]

          SOLR-10042, LUCENE-7838: Fix precommit

          Show
          jira-bot ASF subversion and git services added a comment - Commit d30d012c7c2f9de46a32d7e9eda3b17c51a7fa04 in lucene-solr's branch refs/heads/master from Tomas Fernandez Lobbe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d30d012 ] SOLR-10042 , LUCENE-7838 : Fix precommit
          Hide
          janhoy Jan Høydahl added a comment -

          Thanks Tomas!

          Show
          janhoy Jan Høydahl added a comment - Thanks Tomas!
          Hide
          upayavira Upayavira added a comment -

          SOLR-10042_remove_commented.patch removes stuff that was meant to remind me of unimplemented features. I eventually stopped using that method, but failed to clean up. These comments are redundant and can be removed.

          Show
          upayavira Upayavira added a comment - SOLR-10042 _remove_commented.patch removes stuff that was meant to remind me of unimplemented features. I eventually stopped using that method, but failed to clean up. These comments are redundant and can be removed.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 467af790cbf50b5633204e384c0efbf19fad30de in lucene-solr's branch refs/heads/master2 from Jan Høydahl
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=467af79 ]

          SOLR-10042: Clean up old comments from Angular UI code

          Show
          jira-bot ASF subversion and git services added a comment - Commit 467af790cbf50b5633204e384c0efbf19fad30de in lucene-solr's branch refs/heads/master2 from Jan Høydahl [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=467af79 ] SOLR-10042 : Clean up old comments from Angular UI code
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 467af790cbf50b5633204e384c0efbf19fad30de in lucene-solr's branch refs/heads/master from Jan Høydahl
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=467af79 ]

          SOLR-10042: Clean up old comments from Angular UI code

          Show
          jira-bot ASF subversion and git services added a comment - Commit 467af790cbf50b5633204e384c0efbf19fad30de in lucene-solr's branch refs/heads/master from Jan Høydahl [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=467af79 ] SOLR-10042 : Clean up old comments from Angular UI code

            People

            • Assignee:
              janhoy Jan Høydahl
              Reporter:
              janhoy Jan Høydahl
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development