Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10020

CoreAdminHandler silently swallows some errors

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 6.5, 7.0
    • None
    • None

    Description

      With the setup on SOLR-10006, after removing some index files and starting that Solr instance I tried issuing a REQUESTRECOVERY command and it came back as a success even though nothing actually happened. When the core is accessed, a core init exception is returned by subsequent calls to getCore(). There is no catch block after the try so no error is returned.

      Looking through the code I see several other commands that have a similar pattern:
      FORCEPREPAREFORLEADERSHIP_OP
      LISTSNAPSHOTS_OP
      getCoreStatus

      and perhaps others. getCore() can throw an exception, about the only explicit one it does throw is if the core has an initialization error.

      Attachments

        1. SOLR-10020.patch
          4 kB
          Erick Erickson
        2. SOLR-10020.patch
          4 kB
          Mike Drob
        3. SOLR-10020.patch
          2 kB
          Mike Drob
        4. SOLR-10020.patch
          2 kB
          Mike Drob

        Activity

          People

            erickerickson Erick Erickson
            erickerickson Erick Erickson
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: