Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10011

Refactor PointField & TrieField to share common code

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 6.5, 7.0
    • None
    • None

    Description

      We should eliminate PointTypes and TrieTypes enum to have a common enum for both. That would enable us to share a lot of code between the two field types.

      In the process, fix the bug:
      PointFields with indexed=false, docValues=true seem to be using (Int|Double|Float|Long)Point.newRangeQuery() for performing exact matches and range queries. However, they should instead be using DocValues based range query.

      Attachments

        1. SOLR-10011.patch
          14 kB
          Ishan Chattopadhyaya
        2. SOLR-10011.patch
          15 kB
          Ishan Chattopadhyaya
        3. SOLR-10011.patch
          36 kB
          Ishan Chattopadhyaya
        4. SOLR-10011.patch
          36 kB
          Ishan Chattopadhyaya
        5. SOLR-10011.patch
          42 kB
          Tomas Eduardo Fernandez Lobbe

        Issue Links

          blocks

          New Feature - A new feature of the product, which has yet to be developed. SOLR-5944 Support updates of numeric DocValues

          • Major - Major loss of function.
          • Closed
          is related to

          Task - A task that needs to be done. SOLR-10236 Remove FieldType.getNumericType() from master

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-8396 Add support for PointFields in Solr

          • Major - Major loss of function.
          • Closed

          Activity

            People

              ichattopadhyaya Ishan Chattopadhyaya
              ichattopadhyaya Ishan Chattopadhyaya
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: