[SMXCOMP-867] servicemix-camel performance optimizations

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2011.02
• Component/s: servicemix-camel

Environment

http://svn.apache.org/repos/asf/servicemix/components/trunk/engines/servicemix-camel

• Patch Info: Patch Available
• Assignee: Freeman Yue Fang
• Reporter: Jonathan Anstey
• Created: 19/Apr/11 12:26
• Updated: 20/Apr/11 08:27
• Resolved: 20/Apr/11 08:27

Description

I'm attaching a few small performance optimizations to the JbiBinding in the servicemix-camel component. Nothing Earth shattering here, but there were a few cases where we were doing the same operation twice in a method when only one was required. For example, one particulary bad offender was converting a Camel Message body to a Source object twice:

     public void copyFromCamelToJbi(Message message, NormalizedMessage normalizedMessage) throws MessagingException {
         if (message != null && message.getBody() != null) {
            if (message.getBody(Source.class) == null) {
                 logger.warn("Unable to convert message body of type {} into an XML Source", message.getBody().getClass());
             } else {
                 normalizedMessage.setContent(message.getBody(Source.class));
             }
         }

Attaching a patch shortly...