Uploaded image for project: 'ServiceMix 4'
  1. ServiceMix 4
  2. SMX4-956

Monitor etc/activemq-broker.xml for changes

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.3.0
    • Fix Version/s: 4.4.0
    • Component/s: None
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      When people want to change the configuration in etc/activemq-broker.xml, they also have to explicitly do an osgi:update of the bundle or restart the container after removing the data directory. This is a bit inconvenient, but it also is confusing as all the other configuration files changes are being applied on the fly.

      We should configure FileInstall to also watch the etc/activemq-broker.xml for changes and automatically reconfigure stuff when necessary.

      1. SMX4-956.patch
        3 kB
        Jonathan Anstey

        Issue Links

          Activity

          Hide
          marks1900 Mark S added a comment -

          I personally got burnt on this. I just assumed that configuration files edited inside the "etc" configuration directory, got picked up either automatically or on restart.

          Show
          marks1900 Mark S added a comment - I personally got burnt on this. I just assumed that configuration files edited inside the "etc" configuration directory, got picked up either automatically or on restart.
          Hide
          janstey Jonathan Anstey added a comment -

          Yeah, I have found this really annoying in the past too... gonna take a look into it.

          Show
          janstey Jonathan Anstey added a comment - Yeah, I have found this really annoying in the past too... gonna take a look into it.
          Hide
          janstey Jonathan Anstey added a comment -

          Patch for this issue.

          Show
          janstey Jonathan Anstey added a comment - Patch for this issue.
          Hide
          ffang Freeman Fang added a comment -

          apply patch on behalf of Jon with thanks
          http://svn.apache.org/viewvc?rev=1201684&view=rev

          Show
          ffang Freeman Fang added a comment - apply patch on behalf of Jon with thanks http://svn.apache.org/viewvc?rev=1201684&view=rev
          Hide
          janstey Jonathan Anstey added a comment -

          Thanks Freeman.

          Show
          janstey Jonathan Anstey added a comment - Thanks Freeman.
          Hide
          metatech metatech added a comment -

          Is there any specific reason why the file "activemq-broker.xml" was not simply moved from "etc" to "deploy", so that it is automatically redeployed ?
          Adding a new DirectoryWatcher for this file implies that there are 2 DirectoryWatcher in total for this file : "etc/*" and "etc/activemq-broker.xml". This double DirectoryWatcher is causing interferences due to change done for FELIX-4436.

          Show
          metatech metatech added a comment - Is there any specific reason why the file "activemq-broker.xml" was not simply moved from "etc" to "deploy", so that it is automatically redeployed ? Adding a new DirectoryWatcher for this file implies that there are 2 DirectoryWatcher in total for this file : "etc/*" and "etc/activemq-broker.xml". This double DirectoryWatcher is causing interferences due to change done for FELIX-4436 .

            People

            • Assignee:
              ffang Freeman Fang
              Reporter:
              gertvanthienen Gert Vanthienen
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development