Uploaded image for project: 'ServiceMix 4'
  1. ServiceMix 4
  2. SMX4-791

Make allowCoreThreadTimeOut name consistent across mbeans and properties

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.4.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently different names are used for properties and different in mbean display
      org.apache.servicemix.nmr.osgi.ExecutorConfigurator has allowCoreThreadsTimeout (with 's' and small 'o') and this is the name of the property that should be used in config file for it to work (ExecutorConfig in smx-utils has allowCoreThreadsTimeout too).

      Then ExecutorFactoryImpl uses it to populate allowCoreThreadTimeOut property of thread pool executor (no 's', big 'O')

      if (config.isAllowCoreThreadsTimeout()) {
                  try {
                      Method mth = service.getClass().getMethod("allowCoreThreadTimeOut", new Class[]{boolean.class});
                      mth.invoke(service, new Object[]{Boolean.TRUE});
                  }
      

      So two versions of the name of the same property. Probably all should be changed to the one used on ThreadPoolExecutor as "allowCoreThreadTimeOut"

        Issue Links

          Activity

          Show
          ffang Freeman Fang added a comment - commit fix http://svn.apache.org/viewvc?rev=1086857&view=rev for utils http://svn.apache.org/viewvc?rev=1086865&view=rev for features

            People

            • Assignee:
              ffang Freeman Fang
              Reporter:
              ffang Freeman Fang
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development