Uploaded image for project: 'ServiceMix'
  1. ServiceMix
  2. SM-2119

Hardcoded parameters are used instead of ones in property files in default configuration

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.2
    • Fix Version/s: 3.4.0
    • Component/s: servicemix-core
    • Labels:
      None

      Description

      servicemix.properties contains settings for ActiveMQ host/port/url:
      activemq.port = 61616
      activemq.host = localhost
      activemq.url = tcp://$

      {activemq.host}

      :$

      {activemq.port}

      Same time activemq.xml hardcodes the same information:
      <amq:transportConnector uri="tcp://localhost:61616" discoveryUri="multicast://default"/>
      So if user changes property file (which seems logical) without changing xml file (which might look non logical) to use another port or change localhost to 0.0.0.0 then it will not work.
      Problem could be solved by using placeholder in transport connector:
      <amq:transportConnector uri="$

      {activemq.url}

      " discoveryUri="multicast://default"/>

        Activity

        Hide
        ffang Freeman Fang added a comment -

        commit fix
        http://svn.apache.org/viewvc?rev=1160236&view=rev
        @Nickolay,
        thanks for pointing out this issue

        Show
        ffang Freeman Fang added a comment - commit fix http://svn.apache.org/viewvc?rev=1160236&view=rev @Nickolay, thanks for pointing out this issue

          People

          • Assignee:
            ffang Freeman Fang
            Reporter:
            nickolay_martinov Nikolay Martynov
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development