ServiceMix
  1. ServiceMix
  2. SM-1573

Use of useJBIWrapper flag in smx-cxf-bc consumer and smx-http soap-consumer endpoints is inconsistent

    Details

      Description

      The smx-cxf-bc consumer and smx-http soap-consumer endpoints both support the useJBIWrapper boolean flag. However, smx-cxf-bc consumer interprets this flag to mean forward the message with the soap envelope instead of the jbi wrapper. OTOH, the smx-http soap-consumer interprets it to mean forward the message with just the soap body and neither the soap envelope nor the jbi wrapper.

      I think the smx-http soapConsumer behavior is much more intuitive.

      In SMX 3.3, would it be possible to add a useSOAPEnvelope boolean flag to smx-cxf-bc? The default value for this flag would be false. In addition, it would be an error to set both flags to true.

      When useSOAPEnvelope=true, one would get the same behavior as the current useJBIWrapper=false.

      When useJBIWrapper=false (and useSOAPEnvelope=false), neither envelope would be used, which would result in the same behavior as smx-http consumer useJBIWrapper=false.

      What do you think? I recognize that this is a breaking change. However, I think it is a significant improvement over the current behavior.

      Also, I think adding the useSOAPEnvelope=true boolean flag to the smx-http soapConsumer might be a worthwhile enhancement as well.

      • Ron

        Activity

        Hide
        Freeman Fang added a comment -

        should be fine to add a flag for cxf component.

        Seems we have to break old behavior.

        Show
        Freeman Fang added a comment - should be fine to add a flag for cxf component. Seems we have to break old behavior.
        Hide
        Edell Nolan added a comment -

        We would need to document this well as the useJBIWrapper flag isn't currently documented
        as regards servicemix cxfbc etc but people are using it.

        Show
        Edell Nolan added a comment - We would need to document this well as the useJBIWrapper flag isn't currently documented as regards servicemix cxfbc etc but people are using it.
        Hide
        Freeman Fang added a comment -
        Show
        Freeman Fang added a comment - commit fix http://svn.apache.org/viewvc?rev=711826&view=rev for 3.2 branch http://svn.apache.org/viewvc?rev=711825&view=rev for servicemix-cxf-se component http://svn.apache.org/viewvc?rev=711827&view=rev for servicemix-cxf-bc component
        Hide
        Freeman Fang added a comment -

        add useSOAPEnvelope flag, the default value is true for backward compability
        If useJBIWrapper is true then ignore useSOAPEnvelope. If useJBIWrapper is false and useSOAPEnvelope is true, than same behavior as before(complete soap message), if useJBIWrapper is false and useSOAPEnvelope is false, then only soap body is put in the NMR.
        Same rule apply to the cxf se

        Show
        Freeman Fang added a comment - add useSOAPEnvelope flag, the default value is true for backward compability If useJBIWrapper is true then ignore useSOAPEnvelope. If useJBIWrapper is false and useSOAPEnvelope is true, than same behavior as before(complete soap message), if useJBIWrapper is false and useSOAPEnvelope is false, then only soap body is put in the NMR. Same rule apply to the cxf se

          People

          • Assignee:
            Freeman Fang
            Reporter:
            Ron Gavlin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development