Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-9901

JcrSystemUserValidatorTest contains no tests for system users

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: JCR Resource 3.0.22
    • Fix Version/s: JCR Resource 3.0.24
    • Component/s: JCR
    • Labels:
      None

      Description

      org.apache.sling.jcr.resource comes with a JcrSystemUserValidator that adds validation to service-user-mapping and if enable prevents regular users or groups from being mapped.

      however, JcrSystemUserValidatorTest doesn't contain a single test case verifying if the validation is actually successful for system users (or that disabled system users would not be valid).

      i suspect that this is due to the fact that org.apache.sling.commons.testing.jcr.RepositoryTestBase creates a Jackrabbit repository and has never been adjusted to allow for an Oak repository to be used as test repository. In other words: an attempt to create a system user will fail.

      Robert Munteanu, is there an alternative to the RepositoryTestBase that would operate on a Oak repository?

        Attachments

          Activity

            People

            • Assignee:
              bdelacretaz Bertrand Delacretaz
              Reporter:
              angela Angela Schreiber
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1.5h
                1.5h