[SLING-9858] Get rid of commons testing dependency

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Models Implementation 1.4.16
• Fix Version/s: Models Implementation 1.5.0
• Component/s: Sling Models
• Assignee: Konrad Windszus
• Reporter: Konrad Windszus
• Created: 27/Oct/20 14:00
• Updated: 10/Dec/21 09:26
• Resolved: 28/Oct/20 08:32

Description

Given that there are better alternatives for most packages in Commons Testing (https://issues.apache.org/jira/browse/SLING-7166) we should get rid of the dependency in Models Impl.

As only a mock for SlingHttpServletRequest is used from commons testing AFAICS we should start using https://github.com/apache/sling-org-apache-sling-servlet-helpers/blob/master/src/main/java/org/apache/sling/servlethelpers/MockSlingHttpServletRequest.java instead.

Issue Links

• relates to: SLING-9834 [Sling Models] Caching bug with reused Servlet requests
• relates to: SLING-7166 Deprecate Commons Testing
• links to: GH PR