[SLING-9781] [Sling Models] Caching doesn't work with Wrapped requests

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Models Impl 1.4.12
• Fix Version/s: Models Impl 1.4.14
• Component/s: Extensions
• Assignee: Justin Edelson
• Reporter: Christophe Jelger
• Created: 01/Oct/20 09:34
• Updated: 19/Oct/20 10:30
• Resolved: 05/Oct/20 11:09

Description

The caching of Sling models doesn't work when the original SlingHttpServletRequest is wrapped in a request wrapper, like this is typically done in HTL scripts with the OnDemandReaderRequest wrapper.

The solution is to use the original request when caching models so that any wrapping does not interfere with the caching. When someone enables caching for a model adapted from request, I think the expectation is that caching does happen whenever the original request is wrapped.

I'll provide a PR with a fix.

cc: justinedelson radu as discussed in Slack.

Issue Links

• causes: SLING-9834 [Sling Models] Caching bug with reused Servlet requests
• links to: Pull Request